Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1141943003: Remove cronet dependency on org.apache.http. (Closed)

Created:
5 years, 7 months ago by Yaron
Modified:
5 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove cronet dependency on org.apache.http. Remaps status codes to ones from HttpURLConnection. Changes ConnectTimoutException to SocketTimeoutException. BUG=468861 Committed: https://crrev.com/4746a790d8682c550b2a57381985c3646e51096f Cr-Commit-Position: refs/heads/master@{#330103}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 2 chunks +2 lines, -2 lines 1 comment Download
M components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yaron
https://codereview.chromium.org/1141943003/diff/1/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java File components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java (right): https://codereview.chromium.org/1141943003/diff/1/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java#newcode189 components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java:189: return new SocketTimeoutException("Connection timed out"); Not sure how we ...
5 years, 7 months ago (2015-05-15 15:20:22 UTC) #2
xunjieli
LGTM. I don't see a reference of the ConnectTimeoutException when searching in the internal code ...
5 years, 7 months ago (2015-05-15 15:34:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141943003/1
5 years, 7 months ago (2015-05-15 15:43:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 16:08:58 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:10:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4746a790d8682c550b2a57381985c3646e51096f
Cr-Commit-Position: refs/heads/master@{#330103}

Powered by Google App Engine
This is Rietveld 408576698