Chromium Code Reviews| Index: chrome/browser/ui/webui/about_ui.cc |
| =================================================================== |
| --- chrome/browser/ui/webui/about_ui.cc (revision 170972) |
| +++ chrome/browser/ui/webui/about_ui.cc (working copy) |
| @@ -859,7 +859,7 @@ |
| const std::vector<ProcessData>& browser_processes = processes(); |
| // Aggregate per-process data into browser summary data. |
| - std::wstring log_string; |
| + string16 log_string; |
| for (size_t index = 0; index < browser_processes.size(); index++) { |
| if (browser_processes[index].processes.empty()) |
| continue; |
| @@ -891,17 +891,14 @@ |
| // We log memory info as we record it. |
| if (log_string.length() > 0) |
|
sky
2012/12/06 21:05:01
!empty
|
| - log_string.append(L", "); |
| - log_string.append(UTF16ToWide(browser_processes[index].name)); |
| - log_string.append(L", "); |
| - log_string.append(UTF8ToWide( |
| - base::Int64ToString(aggregate.working_set.priv))); |
| - log_string.append(L", "); |
| - log_string.append(UTF8ToWide( |
| - base::Int64ToString(aggregate.working_set.shared))); |
| - log_string.append(L", "); |
| - log_string.append(UTF8ToWide( |
| - base::Int64ToString(aggregate.working_set.shareable))); |
| + log_string.append(ASCIIToUTF16(", ")); |
| + log_string.append(browser_processes[index].name); |
|
sky
2012/12/06 21:05:01
This feels like more code than it needs to be. How
|
| + log_string.append(ASCIIToUTF16(", ")); |
| + log_string.append(base::Int64ToString16(aggregate.working_set.priv)); |
| + log_string.append(ASCIIToUTF16(", ")); |
| + log_string.append(base::Int64ToString16(aggregate.working_set.shared)); |
| + log_string.append(ASCIIToUTF16(", ")); |
| + log_string.append(base::Int64ToString16(aggregate.working_set.shareable)); |
| } |
| if (log_string.length() > 0) |
|
sky
2012/12/06 21:05:01
!empty
exxi
2012/12/06 22:59:15
Done.
|
| VLOG(1) << "memory: " << log_string; |