Issue 11419315: cros: Fix a comparison of a bool with -1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419315: cros: Fix a comparison of a bool with -1 (Closed)

Created:
8 years ago by Nico

Modified:
8 years ago

Reviewers:
bshe

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cros: Fix a comparison of a bool with -1 BUG=none TBR=bshe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171023

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/chromeos/extensions/wallpaper_private_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bshe

On 2012/12/04 19:33:55, Nico wrote: > Please check that I got the sign right. Thanks. ...

8 years ago (2012-12-04 20:30:53 UTC) #2

Nico

On 2012/12/04 20:30:53, bshe wrote: > On 2012/12/04 19:33:55, Nico wrote: > > Please check ...

8 years ago (2012-12-04 20:32:53 UTC) #3

bshe

8 years ago (2012-12-04 20:35:04 UTC) #4

Message was sent while issue was closed.

On 2012/12/04 20:32:53, Nico wrote:
> On 2012/12/04 20:30:53, bshe wrote:
> > On 2012/12/04 19:33:55, Nico wrote:
> > > Please check that I got the sign right.
> > 
> > Thanks. could you please remove "!" since we dont need it.
> 
> In both cases?

Sorry. Just the latter one:
from
!file_util::ReadFileToString(file_path, data);
to
file_util::ReadFileToString(file_path, data);

Expand Messages | Collapse Messages