Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/extensions/extension_prefs.h

Issue 11419307: Garbage Collect the Storage directory on next profile start after an extension uninstall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address mpcomplete's comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs.h
diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h
index 88a7d0bc1fcf579c143c3f34d3690de34d611db6..e9216e9ead695d49945484997753e1b928d405f2 100644
--- a/chrome/browser/extensions/extension_prefs.h
+++ b/chrome/browser/extensions/extension_prefs.h
@@ -384,25 +384,25 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
// We've downloaded an updated .crx file for the extension, but are waiting
// for idle time to install it.
- void SetIdleInstallInfo(const Extension* extension,
- Extension::State initial_state,
- const syncer::StringOrdinal& page_ordinal);
+ void SetDelayedInstallInfo(const Extension* extension,
+ Extension::State initial_state,
+ const syncer::StringOrdinal& page_ordinal);
// Removes any idle install information we have for the given |extension_id|.
Charlie Reis 2012/12/10 23:22:28 nit: s/idle/delayed/, here and below
awong 2012/12/11 01:18:32 Done.
// Returns true if there was info to remove; false otherwise.
- bool RemoveIdleInstallInfo(const std::string& extension_id);
+ bool RemoveDelayedInstallInfo(const std::string& extension_id);
// Update the prefs to finish the update for an extension.
- bool FinishIdleInstallInfo(const std::string& extension_id);
+ bool FinishDelayedInstallInfo(const std::string& extension_id);
// Returns the ExtensionInfo from the prefs for idle install information for
// |extension_id|, if we have any. Otherwise returns NULL.
- scoped_ptr<ExtensionInfo> GetIdleInstallInfo(
+ scoped_ptr<ExtensionInfo> GetDelayedInstallInfo(
const std::string& extension_id) const;
// Returns information about all the extensions that have pending idle
// install information.
- scoped_ptr<ExtensionsInfo> GetAllIdleInstallInfo() const;
+ scoped_ptr<ExtensionsInfo> GetAllDelayedInstallInfo() const;
// We allow the web store to set a string containing login information when a
// purchase is made, so that when a user logs into sync with a different
@@ -503,6 +503,12 @@ class ExtensionPrefs : public ContentSettingsStore::Observer,
// prefs::kExtensionAllowedInstallSites for more information.
URLPatternSet GetAllowedInstallSites();
+ // Schedules garbage collection of an extension's on-disk data on the next
+ // start of this ExtensionService. Applies only to extensions with isolated
+ // storage.
+ void SetNeedsStorageGarbageCollection(bool value);
+ bool NeedsStorageGarbageCollection();
+
private:
friend class ExtensionPrefsBlacklistedExtensions; // Unit test.
friend class ExtensionPrefsUninstallExtension; // Unit test.

Powered by Google App Engine
This is Rietveld 408576698