Garbage Collect the Storage directory on next profile start after an extension uninstall.

content/browser/storage_partition_impl_map.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_STORAGE_PARTITION_MAP_H_
 #define CONTENT_BROWSER_STORAGE_PARTITION_MAP_H_
 
 #include <map>
 #include <string>
 
 #include "base/callback_forward.h"
 #include "base/gtest_prod_util.h"
+#include "base/hash_tables.h"
 #include "base/supports_user_data.h"
 #include "content/browser/storage_partition_impl.h"
 #include "content/public/browser/browser_context.h"
 
 class FilePath;
 
+namespace base {
+class SequencedTaskRunner;
+}  // namespace base
+
 namespace content {
 
 class BrowserContext;
 
 // A std::string to StoragePartition map for use with SupportsUserData APIs.
 class StoragePartitionImplMap : public base::SupportsUserData::Data {
  public:
   explicit StoragePartitionImplMap(BrowserContext* browser_context);
 
   virtual ~StoragePartitionImplMap();
 
   // This map retains ownership of the returned StoragePartition objects.
   StoragePartitionImpl* Get(const std::string& partition_domain,
                             const std::string& partition_name,
                             bool in_memory);
 
   // Starts an asynchronous best-effort attempt to delete all on-disk storage
   // related to |site|, avoiding any directories that are known to be in use.
-  void AsyncObliterate(const GURL& site);
+  //
+  // |on_gc_required| is called if the AsyncObliterate() call was unable to
+  // fully clean the on-disk storage requiring a call to GarbageCollect() on
+  // the next browser start.
+  void AsyncObliterate(const GURL& site, const base::Closure& on_gc_required);
+
+  // Examines the on disk storage and removes any entires that are not listed in

[Charlie Reis, 2012/12/10 23:22:28]

nit: on-disk

[awong, 2012/12/11 01:18:32]

Done.

+  // the active_paths, or in use by current entires in the storage partition.

[Charlie Reis, 2012/12/10 23:22:28]

nit: entries

Can you also mention that the done closure is called when it finishes?

[awong, 2012/12/11 01:18:32]

Done.

+  void GarbageCollect(scoped_ptr<base::hash_set<FilePath> > active_paths,
+                      const base::Closure& done);
 
   void ForEach(const BrowserContext::StoragePartitionCallback& callback);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionConfigTest, OperatorLess);
 
   // Each StoragePartition is uniquely identified by which partition domain
   // it belongs to (such as an app or the browser itself), the user supplied
   // partition name and the bit indicating whether it should be persisted on
   // disk or not. This structure contains those elements and is used as
@@ skipping 46 matching lines @@
   // This must always be called *after* |partition| has been added to the
   // partitions_.
   //
   // TODO(ajwong): Is there a way to make it so that Get()'s implementation
   // doesn't need to be aware of this ordering?  Revisit when refactoring
   // ResourceContext and AppCache to respect storage partitions.
   void PostCreateInitialization(StoragePartitionImpl* partition,
                                 bool in_memory);
 
   BrowserContext* browser_context_;  // Not Owned.
+  scoped_refptr<base::SequencedTaskRunner> file_access_runner_;
   PartitionMap partitions_;
 
   // Set to true when the ResourceContext for the associated |browser_context_|
   // is initialized. Can never return to false.
   bool resource_context_initialized_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_STORAGE_PARTITION_MAP_H_