Garbage Collect the Storage directory on next profile start after an extension uninstall.

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 807 matching lines @@
 
   // Helper to determine if an extension is idle, and it should be safe
   // to update the extension.
   bool IsExtensionIdle(const std::string& extension_id) const;
 
   // Helper to determine if updating an extensions should proceed immediately,
   // or if we should delay the update until further notice.
   bool ShouldDelayExtensionUpdate(const std::string& extension_id,
                                   bool wait_for_idle) const;
 
+  // Helper to search remove an storage directories for extensions with

[Charlie Reis, 2012/12/05 02:25:40]

nit: "search remove an" typo

[awong, 2012/12/08 01:45:23]

Done.

+  // isolated storage that have been orphaned by an uninstall.
+  void GarbageCollectIsolatedStorage();
+  void OnGarbageCollectIsolatedStorageFinished();
+
   // extensions::Blacklist::Observer implementation.
   virtual void OnBlacklistUpdated() OVERRIDE;
 
+  void set_delay_all_installs(bool value) { delay_all_installs_ = value; }

[Charlie Reis, 2012/12/05 02:25:40]

Please add a comment to these saying why they're needed.

[awong, 2012/12/08 01:45:23]

Done.

+  bool delay_all_installs() const { return delay_all_installs_; }

[Charlie Reis, 2012/12/05 02:25:40]

nit: Maybe should_delay_all_installs()?
(It sounds like a command at the moment.)

[awong, 2012/12/08 01:45:23]

How about installs_delayed()?  should_delay_all_installs is very long...

+
   // The normal profile associated with this ExtensionService.
   Profile* profile_;
 
   // The ExtensionSystem for the profile above.
   extensions::ExtensionSystem* system_;
 
   // Preferences for the owning profile (weak reference).
   extensions::ExtensionPrefs* extension_prefs_;
 
   // Settings for the owning profile.
   scoped_ptr<extensions::SettingsFrontend> settings_frontend_;
 
   // The current list of installed extensions.
   ExtensionSet extensions_;
 
   // The list of installed extensions that have been disabled.
   ExtensionSet disabled_extensions_;
 
   // The list of installed extensions that have been terminated.
   ExtensionSet terminated_extensions_;
 
   // The list of extension updates that are waiting to be installed.
   ExtensionSet pending_extension_updates_;
 
+  // The list of extension installs delayed by |delay_all_installs_|.
+  struct PendingInstall {
+    PendingInstall(const extensions::Extension* extension,
+                   const syncer::StringOrdinal& page_ordinal,
+                   bool has_requirement_errors,
+                   bool wait_for_idle);
+    ~PendingInstall();
+
+    scoped_refptr<const extensions::Extension> extension;
+    syncer::StringOrdinal page_ordinal;
+    bool has_requirement_errors;
+    bool wait_for_idle;
+  };
+  std::vector<PendingInstall> pending_extension_installs_;
+
   // Hold the set of pending extensions.
   extensions::PendingExtensionManager pending_extension_manager_;
 
   // The map of extension IDs to their runtime data.
   ExtensionRuntimeDataMap extension_runtime_data_;
 
   // The full path to the directory where extensions are installed.
   FilePath install_directory_;
 
   // Whether or not extensions are enabled.
@@ skipping 103 matching lines @@
   // has to wait for the external providers.  Used in
   // OnAllExternalProvidersReady() to determine if an update check is needed to
   // install pending extensions.
   bool update_once_all_providers_are_ready_;
 
   // Set when the browser is terminating. Prevents us from installing or
   // updating additional extensions and allows in-progress installations to
   // decide to abort.
   bool browser_terminating_;
 
+  // Set to true to delay all new extension installations. Allows garbage
+  // collection of on disk state to proceed without worrying about race
+  // conditions caused by extension installations during the garbage
+  // collection process.
+  bool delay_all_installs_;
+
   NaClModuleInfoList nacl_module_list_;
 
   extensions::AppSyncBundle app_sync_bundle_;
   extensions::ExtensionSyncBundle extension_sync_bundle_;
 
   extensions::ProcessMap process_map_;
 
   extensions::AppShortcutManager app_shortcut_manager_;
 
   scoped_ptr<ExtensionErrorUI> extension_error_ui_;
   // Sequenced task runner for extension related file operations.
   scoped_refptr<base::SequencedTaskRunner> file_task_runner_;
 
 #if defined(ENABLE_EXTENSIONS)
   scoped_ptr<extensions::ExtensionActionStorageManager>
       extension_action_storage_manager_;
 #endif
 
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsWithUnlimtedStorage);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsAndCheckStorageProtection);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_