Issue 11419306: Don't disable Caps Lock when Shift+<non-modifier-key> is pressed and Shift is released first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419306: Don't disable Caps Lock when Shift+<non-modifier-key> is pressed and Shift is released first. (Closed)

Created:
8 years ago by Yusuke Sato

Modified:
8 years ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, danakj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't disable Caps Lock when Shift+<non-modifier-key> is pressed and then Shift is released first. BUG=163804 TEST=ran new tests in accelerator_controller_unittest.cc. tested manually too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170895

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -9 lines)			Patch
	M	ash/accelerators/accelerator_controller.cc	View		4 chunks	+10 lines, -9 lines	0 comments	Download
	M	ash/accelerators/accelerator_controller_unittest.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Yusuke Sato

Daniel, could you have a look? I found that Dana's release accelerator handling code for ...

8 years ago (2012-12-04 02:23:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/11419306/1

8 years ago (2012-12-04 03:12:28 UTC) #3

commit-bot: I haz the power

8 years ago (2012-12-04 06:26:12 UTC) #4

Retried try job too often on mac_rel for step(s) browser_tests