Issue 11419302: mac: Fix tab strip outline when dragging out a tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419302: mac: Fix tab strip outline when dragging out a tab. (Closed)

Created:
8 years ago by Nico

Modified:
8 years ago

Reviewers:
sail

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Fix tab strip outline when dragging out a tab. The tab drawing code had a spurious "+ 1". Move that into the tab height, so that other places that look at this (such as the tab drag-out code) get a consistent value. The new height also matches the height of the corresponding bitmap: chrome/app/theme/def_100/mac/tab_active_left.png ist 29px high and has empty pixels at the top. BUG=52468 TEST=drag out tab. tab in new window looks good. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171013

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download