Issue 11419286: Clean up the interactive_ui_tests TSan bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419286: Clean up the interactive_ui_tests TSan bot (Closed)

Created:
8 years ago by Timur Iskhodzhanov

Modified:
8 years ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Clean up the interactive_ui_tests TSan bot Widen some suppression, add general Histogram suppression (hope the other ones will be unused then); exclude some tests. BUG=163880 TBR=glider NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170726

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
	M	tools/valgrind/gtest_exclude/interactive_ui_tests.gtest.txt	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	tools/valgrind/tsan/suppressions.txt	View		2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/11419286/1

8 years ago (2012-12-03 11:15:27 UTC) #2

commit-bot: I haz the power

8 years ago (2012-12-03 11:15:28 UTC) #3

Presubmit check for 11419286-1 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1259, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1107, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1024, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 31, in CheckChangeOnCommit
  File "<string>", line 20, in CheckChange
  File
"/b/commit-queue/workdir/chromium/tools/valgrind/tsan/../suppressions.py", line
32, in <module>
    import path_utils
ImportError: No module named path_utils

Expand Messages | Collapse Messages