Move second internal recursion to a precomputation in layer_tree_host_common.cc

cc/layer_impl.h

Index: cc/layer_impl.h
diff --git a/cc/layer_impl.h b/cc/layer_impl.h
index 3e72d20a70220a488d3b675637e3892bbd49d503..ab7da46ba08952fef6c7a202bf23f3f02d6d7ec4 100644
--- a/cc/layer_impl.h
+++ b/cc/layer_impl.h
@@ -99,10 +99,9 @@ public:
     bool forceRenderSurface() const { return m_forceRenderSurface; }
     void setForceRenderSurface(bool force) { m_forceRenderSurface = force; }
 
-    // Returns 0 if none of the layer's descendants has content to draw,
-    // 1 if exactly one descendant has content to draw, or a number >1
-    // (but necessary the exact number of descendants) otherwise.
-    virtual int descendantsDrawContent();
+    // This value does not consider the layer itself, only its descendants.
+    virtual int numDescendantsThatDrawContent() { return m_numDescendantsThatDrawContent; }

[danakj, 2012/12/03 18:33:41]

i like the function name

+    void setNumDescendantsThatDrawContent(int num) { m_numDescendantsThatDrawContent = num; }

[danakj, 2012/12/03 18:33:41]

I kinda don't like this. Set/get seems simple but then sometimes the set does
nothing, even tho the variable would be set on the class. Then maybe members of
layer_impl.cc end up using m_numDescendantsThatDrawContent instead of the
function and have the wrong value..

It seems awkward to me.

 
     void setAnchorPoint(const gfx::PointF&);
     const gfx::PointF& anchorPoint() const { return m_anchorPoint; }
@@ -423,6 +422,8 @@ private:
     // Uses layer's content space.
     gfx::RectF m_updateRect;
 
+    bool m_numDescendantsThatDrawContent;

[slavi, 2012/12/03 21:33:42]

That should be an int.

+
     // Manages animations for this layer.
     scoped_ptr<LayerAnimationController> m_layerAnimationController;