google_apis: Remove some functions from test_server::HttpServer

google_apis: Remove some functions from test_server::HttpServer

These functions are not used. We can add them back if needed.
Less code to maintain is preferable.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170843

[mtomasz, 2012-12-03 23:08:24]

lgtm with one nit

https://codereview.chromium.org/11419283/diff/1/chrome/browser/google_apis/te...
File chrome/browser/google_apis/test_server/http_server.h (right):

https://codereview.chromium.org/11419283/diff/1/chrome/browser/google_apis/te...
chrome/browser/google_apis/test_server/http_server.h:33: // Class providing a
HTTP server for testing purpose. This is a basic server
nit: Please update this comment.

[satorux1, 2012-12-03 23:48:14]

https://codereview.chromium.org/11419283/diff/1/chrome/browser/google_apis/te...
File chrome/browser/google_apis/test_server/http_server.h (right):

https://codereview.chromium.org/11419283/diff/1/chrome/browser/google_apis/te...
chrome/browser/google_apis/test_server/http_server.h:33: // Class providing a
HTTP server for testing purpose. This is a basic server
On 2012/12/03 23:08:24, mtomasz wrote:
> nit: Please update this comment.

Good catch. Done!

[tfarina, 2013-01-19 15:44:27]

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
File chrome/browser/google_apis/test_server/http_server.h (right):

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:59: //   return
http_response.Pass();
this function doesn't return scoped_ptr<test_server::HttpResponse>.

Did you really mean to return here? Or the type should be changed from void?

[tfarina, 2013-01-19 18:34:30]

I think I'll prepare a patch to address some of the nits below ;)

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
File chrome/browser/google_apis/test_server/http_server.h (right):

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:31: };
nit: DISALLOW_COPY_AND_ASSGIN?

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:45: //  
test_server->RegisterRequestHandler(
s/test_server->/test_server_->

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:49: // void
HandleRequest(const HttpRequest& request) {
s/void/scoped_ptr<test_server::HttpResponse> ?

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:50: //   GURL absolute_url
= test_server_.GetURL(request.relative_url);
s/test_server_./test_server_->

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:62: class HttpServer :
private net::StreamListenSocket::Delegate {
does this needs to be private?

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:67: // Creates a http test
server. InitializeAndWaitUntilReady() must be called
s/a/an?

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:86: GURL GetBaseURL()
const;
this can be just:

const GURL& base_url() const { return base_url_; }

https://codereview.chromium.org/11419283/diff/5002/chrome/browser/google_apis...
chrome/browser/google_apis/test_server/http_server.h:112:
scoped_ptr<HttpRequest> request);
could we have passed this by const-ref?