Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 11419281: DriveFileSyncService listens to OnNetworkConnected event to restart synchronization (Closed)

Created:
8 years ago by nhiroki
Modified:
8 years ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, calvinlo
Visibility:
Public.

Description

DriveFileSyncService listens to OnNetworkConnected event to restart synchronization BUG=161436 TEST=manual (Launch test app -> Disconnect network -> Connect network -> Receive notification) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170931

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_client.h View 1 2 3 4 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client.cc View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Could you review this? I manually checked this works well. (This patch is based on ...
8 years ago (2012-12-03 05:31:17 UTC) #1
kinuko
looking good to me https://codereview.chromium.org/11419281/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/11419281/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode510 chrome/browser/sync_file_system/drive_file_sync_service.cc:510: state_ = REMOTE_SERVICE_OK; as in ...
8 years ago (2012-12-03 06:18:48 UTC) #2
nhiroki
Updated. Thanks! https://codereview.chromium.org/11419281/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (right): https://codereview.chromium.org/11419281/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.cc#newcode510 chrome/browser/sync_file_system/drive_file_sync_service.cc:510: state_ = REMOTE_SERVICE_OK; On 2012/12/03 06:18:48, kinuko ...
8 years ago (2012-12-03 06:48:53 UTC) #3
kinuko
8 years ago (2012-12-03 06:57:17 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698