Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 11419271: Revert "Use WS_POPUP for ash_unittests" (Closed)

Created:
8 years ago by oshima
Modified:
8 years ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert "Use WS_POPUP for ash_unittests" Use WS_POPUP for ash_unittests - Layout test windows starting from (1,1) and move mouse to (0,0) so that they don't overlap unless test moves the cursor. - Enabled disabled tests. - RootWindowHostWin::SetBounds should move the window and call OnHostResized when the scale factor has changed. This also seems to fix the desktop size limitation issue (148691) probably because a popup window can be larger than the desktop size. TBR=oshima@chromium.org BUG=150986, 157817, 141577, 148691 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -103 lines) Patch
M ash/dip_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M ash/display/display_controller_unittest.cc View 7 chunks +29 lines, -13 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 10 chunks +51 lines, -13 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/screen_ash_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 9 chunks +35 lines, -6 lines 0 comments Download
M ui/aura/root_window.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_win.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/aura/root_window_host_win.cc View 4 chunks +2 lines, -28 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698