crypto/hmac_nss.cc - Issue 11419270: Use size_t as the type of key_length and digest_length arguments of HMAC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/hmac_nss.cc

Issue 11419270: Use size_t as the type of key_length and digest_length arguments of HMAC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Remove the DCHECK on a digest_length of 0 from hmac_openssl.cc Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/hmac_nss.cc

===================================================================

--- crypto/hmac_nss.cc (revision 170598)

+++ crypto/hmac_nss.cc (working copy)

@@ -39,7 +39,7 @@

HMAC::~HMAC() {

}

-bool HMAC::Init(const unsigned char *key, int key_length) {

+bool HMAC::Init(const unsigned char *key, size_t key_length) {

EnsureNSSInit();

if (plat_->slot_.get()) {

@@ -75,7 +75,7 @@

bool HMAC::Sign(const base::StringPiece& data,

unsigned char* digest,

- int digest_length) const {

+ size_t digest_length) const {

if (!plat_->sym_key_.get()) {

// Init has not been called before Sign.

NOTREACHED();

« no previous file with comments | « crypto/hmac.cc ('k') | crypto/hmac_openssl.cc » ('j') | no next file with comments »