chrome/browser/internal_auth.cc - Issue 11419270: Use size_t as the type of key_length and digest_length arguments of HMAC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/internal_auth.cc

Issue 11419270: Use size_t as the type of key_length and digest_length arguments of HMAC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Remove the DCHECK on a digest_length of 0 from hmac_openssl.cc Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/internal_auth.cc

===================================================================

--- chrome/browser/internal_auth.cc (revision 170598)

+++ chrome/browser/internal_auth.cc (working copy)

@@ -65,7 +65,7 @@

const char kVarValueSeparator = '=';

const size_t kKeySizeInBytes = 128 / 8;

-const int kHMACSizeInBytes = 256 / 8;

+const size_t kHMACSizeInBytes = 256 / 8;

// Length of base64 string required to encode given number of raw octets.

#define BASE64_PER_RAW(X) (X > 0 ? ((X - 1) / 3 + 1) * 4 : 0)

« no previous file with comments | « no previous file | chrome/nacl/nacl_validation_query.h » ('j') | no next file with comments »