Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 11419270: Use size_t as the type of key_length and digest_length arguments of HMAC. (Closed)

Created:
8 years ago by wtc
Modified:
8 years ago
Reviewers:
bradnelson, agl, bradn, Nico
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Use size_t as the type of the key_length and digest_length arguments of HMAC::Init() and HMAC::Sign(). R=agl@chromium.org,bradnelson@chromium.org,thakis@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170852

Patch Set 1 #

Patch Set 2 : Fix compilation errors #

Total comments: 1

Patch Set 3 : Remove the DCHECK on a digest_length of 0 from hmac_openssl.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M chrome/browser/internal_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_validation_query.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl/nacl_validation_query.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M crypto/hmac.h View 3 chunks +3 lines, -5 lines 0 comments Download
M crypto/hmac.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/hmac_nss.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/hmac_openssl.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M crypto/hmac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/hmac_win.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
agl: please review the entire CL. I noticed this problem when I reviewed your HMAC ...
8 years ago (2012-12-01 01:39:23 UTC) #1
Nico
internal_auth lgtm Trybots look fairly red though.
8 years ago (2012-12-01 01:47:37 UTC) #2
agl
lgtm https://codereview.chromium.org/11419270/diff/2006/crypto/hmac_openssl.cc File crypto/hmac_openssl.cc (right): https://codereview.chromium.org/11419270/diff/2006/crypto/hmac_openssl.cc#newcode46 crypto/hmac_openssl.cc:46: DCHECK_NE(digest_length, 0u); This change causes digest_length==0 to be ...
8 years ago (2012-12-03 14:48:01 UTC) #3
bradn
LGTM on nacl files.
8 years ago (2012-12-03 17:52:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/11419270/3005
8 years ago (2012-12-03 18:55:16 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-04 00:50:37 UTC) #6
Message was sent while issue was closed.
Change committed as 170852

Powered by Google App Engine
This is Rietveld 408576698