| Index: base/process_util.h
|
| diff --git a/base/process_util.h b/base/process_util.h
|
| index f2d374c8fef2ed76b13ea783285f838871a8b35b..fe21adf56e06349bb75625c1dd4a91e93885d5ce 100644
|
| --- a/base/process_util.h
|
| +++ b/base/process_util.h
|
| @@ -240,6 +240,9 @@ struct LaunchOptions {
|
| #if defined(OS_WIN)
|
| start_hidden(false), inherit_handles(false), as_user(NULL),
|
| empty_desktop_name(false), job_handle(NULL),
|
| + stdin_handle(NULL),
|
| + stdout_handle(NULL),
|
| + stderr_handle(NULL),
|
| force_breakaway_from_job_(false)
|
| #else
|
| environ(NULL), fds_to_remap(NULL), maximize_rlimits(NULL),
|
| @@ -262,7 +265,10 @@ struct LaunchOptions {
|
| #if defined(OS_WIN)
|
| bool start_hidden;
|
|
|
| - // If true, the new process inherits handles from the parent.
|
| + // If true, the new process inherits handles from the parent. In production
|
| + // code this flag should be used only when running short-lived, trusted
|
| + // binaries, because open handles from other libraries and subsystems will
|
| + // leak to the child process, causing errors such as open socket hangs.
|
| bool inherit_handles;
|
|
|
| // If non-NULL, runs as if the user represented by the token had launched it.
|
| @@ -282,6 +288,14 @@ struct LaunchOptions {
|
| // the job object fails.
|
| HANDLE job_handle;
|
|
|
| + // Handles for the redirection of stdin, stdout and stderr. The handles must
|
| + // be inheritable. Caller should either set all three of them or none (i.e.
|
| + // there is no way to redirect stderr without redirecting stdin). The
|
| + // |inherit_handles| flag must be set to true when redirecting stdio stream.
|
| + HANDLE stdin_handle;
|
| + HANDLE stdout_handle;
|
| + HANDLE stderr_handle;
|
| +
|
| // If set to true, ensures that the child process is launched with the
|
| // CREATE_BREAKAWAY_FROM_JOB flag which allows it to breakout of the parent
|
| // job if any.
|
|
|