Add stdin_handle and stdout_handle in base::LaunchOptions.

base/process_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file/namespace contains utility functions for enumerating, ending and
 // computing statistics of processes.
 
 #ifndef BASE_PROCESS_UTIL_H_
 #define BASE_PROCESS_UTIL_H_
 
@@ skipping 222 matching lines @@
 typedef int* LaunchSynchronizationHandle;
 #endif  // defined(OS_MACOSX)
 
 // Options for launching a subprocess that are passed to LaunchProcess().
 // The default constructor constructs the object with default options.
 struct LaunchOptions {
   LaunchOptions() : wait(false),
 #if defined(OS_WIN)
                     start_hidden(false), inherit_handles(false), as_user(NULL),
                     empty_desktop_name(false), job_handle(NULL),
+                    stdin_handle(NULL),
+                    stdout_handle(NULL),
+                    stderr_handle(NULL),
                     force_breakaway_from_job_(false)
 #else
                     environ(NULL), fds_to_remap(NULL), maximize_rlimits(NULL),
                     new_process_group(false)
 #if defined(OS_LINUX)
                   , clone_flags(0)
 #endif  // OS_LINUX
 #if defined(OS_CHROMEOS)
                   , ctrl_terminal_fd(-1)
 #endif  // OS_CHROMEOS
 #if defined(OS_MACOSX)
                   , synchronize(NULL)
 #endif  // defined(OS_MACOSX)
 #endif  // !defined(OS_WIN)
       {}
 
   // If true, wait for the process to complete.
   bool wait;
 
 #if defined(OS_WIN)
   bool start_hidden;
 
-  // If true, the new process inherits handles from the parent.
+  // If true, the new process inherits handles from the parent. In production
+  // code this flag should be used only when running trusted binaries, because
+  // it may cause some handles to be leaked to the process being launched.

[jschuh, 2013/01/04 21:57:06]

More accurately, it should be something like:

... this flag should be used only when running short-lived, trusted binaries,
because open handles from other libraries and subsystems will leak to the child
process, causing errors such as open socket hangs.

[Sergey Ulanov, 2013/01/05 00:33:05]

Done.

   bool inherit_handles;
 
   // If non-NULL, runs as if the user represented by the token had launched it.
   // Whether the application is visible on the interactive desktop depends on
   // the token belonging to an interactive logon session.
   //
   // To avoid hard to diagnose problems, when specified this loads the
   // environment variables associated with the user and if this operation fails
   // the entire call fails as well.
   UserTokenHandle as_user;
 
   // If true, use an empty string for the desktop name.
   bool empty_desktop_name;
 
   // If non-NULL, launches the application in that job object. The process will
   // be terminated immediately and LaunchProcess() will fail if assignment to
   // the job object fails.
   HANDLE job_handle;
 
+  // Handles for the redirection of stdin, stdout and stderr. The handles must
+  // be inheritable. Caller should either set all three of them or none (i.e.
+  // there is no way to redirect stderr without redirecting stdin). The
+  // |inherit_handles| flag must be set to true when redirecting stdio stream.
+  HANDLE stdin_handle;
+  HANDLE stdout_handle;
+  HANDLE stderr_handle;
+
   // If set to true, ensures that the child process is launched with the
   // CREATE_BREAKAWAY_FROM_JOB flag which allows it to breakout of the parent
   // job if any.
   bool force_breakaway_from_job_;
 #else
   // If non-NULL, set/unset environment variables.
   // See documentation of AlterEnvironment().
   // This pointer is owned by the caller and must live through the
   // call to LaunchProcess().
   const EnvironmentVector* environ;
@@ skipping 588 matching lines @@
 // YOUR CODE IS LIKELY TO BE REVERTED.  THANK YOU.
 //
 // TODO(shess): Weird place to put it, but this is where the OOM
 // killer currently lives.
 BASE_EXPORT void* UncheckedMalloc(size_t size);
 #endif  // defined(OS_MACOSX)
 
 }  // namespace base
 
 #endif  // BASE_PROCESS_UTIL_H_