Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 11419265: Revert 170360 (Closed)

Created:
8 years ago by Jamie
Modified:
8 years ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert 170360 > Use AutoThread in ChromotingHostContext & NPAPI plugin. > > Callers now create ChromotingHostContext to create a set of threads > for host tasks to run on, and pass the threads' TaskRunners to each > host component explicitly. The ChromotingHostContext can then be > torn down as soon as the caller no longer needs to create new > components using the threads, and the threads themselves will exit > only when the created components no longer require them. > > This is a re-land of 11094056, which failed on the valgrind & Windows TSan bots due to ChromotingHostContext.StartAndStop not running its message loop to allow the context's threads join tasks to execute. > > TBR=alexeypa > > Review URL: https://chromiumcodereview.appspot.com/11316247 TBR=wez@chromium.org BUG=163702 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -135 lines) Patch
M remoting/host/chromoting_host_context.h View 2 chunks +45 lines, -30 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 1 chunk +64 lines, -58 lines 0 comments Download
M remoting/host/chromoting_host_context_unittest.cc View 2 chunks +11 lines, -19 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 5 chunks +28 lines, -13 lines 0 comments Download
M remoting/host/desktop_environment_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +17 lines, -0 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M remoting/host/plugin/host_script_object.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M remoting/host/win/session_desktop_environment_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Jamie
8 years ago (2012-11-30 23:27:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698