Add a InitializeNetworkSessionParams method IOThread to remove duplicate code.

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/api/prefs/pref_member.h"
 #include "chrome/browser/net/ssl_config_service_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/browser_thread_delegate.h"
 #include "net/base/network_change_notifier.h"
+#include "net/http/http_network_session.h"
 
 class ChromeNetLog;
 class CommandLine;
 class PrefProxyConfigTrackerImpl;
 class PrefService;
 class SystemURLRequestContextGetter;
 
 namespace chrome_browser_net {
 class DnsProbeService;
 class HttpPipeliningCompatibilityClient;
@@ skipping 45 matching lines @@
       explicit SystemRequestContextLeakChecker(Globals* globals);
       ~SystemRequestContextLeakChecker();
 
      private:
       Globals* const globals_;
     };
 
     Globals();
     ~Globals();
 
+    void InitializeNetworkSessionParams(
+        net::HttpNetworkSession::Params* params) const;

[Ryan Sleevi, 2012/11/30 00:10:05]

Globals is already a public object, so is there a reason this interface needs to
leak into the header, as opposed to being an internal method in an unnamed
namespace?

To put it differently: Is there anyone, beyond this .cc file, who would expect
to use this?

[Ryan Hamilton, 2012/11/30 00:17:59]

I would only expect the .cc file to call this method.  That being said, if I
don't make this a method of Globals, and instead made it a method in an unnamed
namespace, it would require sticking "globals." onto each one of the
assignments.  *yuck*  I much prefer the shorter lines.  But if you feel
strongly, I'll move it.

+
     // The "system" NetworkDelegate, used for Profile-agnostic network events.
     scoped_ptr<net::NetworkDelegate> system_network_delegate;
     scoped_ptr<net::HostResolver> host_resolver;
     scoped_ptr<net::CertVerifier> cert_verifier;
     // This TransportSecurityState doesn't load or save any state. It's only
     // used to enforce pinning for system requests and will only use built-in
     // pins.
     scoped_ptr<net::TransportSecurityState> transport_security_state;
     scoped_refptr<net::SSLConfigService> ssl_config_service;
     scoped_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory;
@@ skipping 166 matching lines @@
 
   // True if SPDY is disabled by policy.
   bool is_spdy_disabled_by_policy_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_