Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: tools/gyp/configurations_android.gypi

Issue 11419237: Shared library for embedding VM in Android apps. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gyp/configurations_android.gypi
===================================================================
--- tools/gyp/configurations_android.gypi (revision 15456)
+++ tools/gyp/configurations_android.gypi (working copy)
@@ -40,7 +40,35 @@
'ANDROID',
],
'configurations': {
+ 'Dart_Debug': {
+ 'defines': [
+ 'DEBUG',
+ ],
+ },
+ 'Dart_Release': {
vsm 2012/11/29 23:13:30 Why do you need Release and Dart_Release?
gram 2012/11/29 23:23:23 We probably don't - but Release was there before,
vsm 2012/11/29 23:41:32 Sure, I'd get rid of the old code if it doesn't se
+ 'defines': [
+ 'NDEBUG',
+ ],
+ 'cflags!': [
+ '-O2',
+ '-Os',
+ ],
+ 'cflags': [
+ '-fdata-sections',
+ '-ffunction-sections',
+ '-fomit-frame-pointer',
+ '-O3',
+ ],
+ }, # Release
vsm 2012/11/29 23:13:30 I think "#Release" meant of end-of-"Release" in th
gram 2012/11/29 23:23:23 Done.
+ 'Debug': {
+ 'defines': [
+ 'DEBUG',
+ ],
+ },
'Release': {
+ 'defines': [
+ 'NDEBUG',
+ ],
'cflags!': [
'-O2',
'-Os',
« samples/android_embedder/android_embedder.gyp ('K') | « samples/android_embedder/support_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698