Issue 11419233: intents: Kill deprecated SendReplyMessage method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419233: intents: Kill deprecated SendReplyMessage method. (Closed)

Created:
8 years ago by tfarina

Modified:
8 years ago

Reviewers:
Greg Billock

CC:
chromium-reviews, groby+watch_chromium.org, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

intents: Kill deprecated SendReplyMessage method. This patch removes all the usages of deprecated SendReplyMessage() method from WebIntentsDispatcher API. This was a TODO for smckay. R=gbillock@chromium.org TBR=jam@chromium.org # for trivia API removal. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170452

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -42 lines)			Patch
M	chrome/browser/extensions/api/app_runtime/app_runtime_api.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/intents/native_services_browsertest.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration_unittest.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/intents/internal_web_intents_dispatcher.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/intents/internal_web_intents_dispatcher.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/intents/internal_web_intents_dispatcher_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/intents/web_intents_dispatcher_impl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/intents/web_intents_dispatcher_impl.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/public/browser/web_intents_dispatcher.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Greg Billock

8 years ago (2012-11-29 20:46:09 UTC) #2

On 2012/11/29 19:32:01, tfarina wrote:
> Hi Greg, could you review this to me?
> 
> Thanks,

lgtm

Expand Messages | Collapse Messages