tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py - Issue 1141923004: Update experiment test to only verify /exptest/... are bypassed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 1141923004: Update experiment test to only verify /exptest/... are bypassed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

index fba1d99bfcfbc76684104e6ef6ae5db7cf97576b..edd9ae56f95e934f4911c53197d82d602f8d97b3 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

@@ -292,7 +292,7 @@ class ChromeProxyExpDirective(ChromeProxyValidation):

options.AppendExtraBrowserArgs('--data-reduction-proxy-experiment=test')

def AddResults(self, tab, results):

- self._metrics.AddResultsForBypass(tab, results)

+ self._metrics.AddResultsForBypass(tab, results, url_pattern='/exptest/')

class ChromeProxyHTTPToDirectFallback(ChromeProxyValidation):

« no previous file with comments | « no previous file | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('J')