Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1141923004: Update experiment test to only verify /exptest/... are bypassed (Closed)

Created:
5 years, 7 months ago by bustamante1
Modified:
5 years, 7 months ago
Reviewers:
sclittle, bustamante
CC:
chromium-reviews, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update experiment test to only verify /exptest/... are bypassed The exp_directive test verifies the experiment flag is passed to the page, by bypassing any request to http://aws1.mdw.la/exptest/... when the flag --data-reduction-proxy-experiment=test is set. Which works as expected. However the favicon request from http://aws1.mdw.la/favicon.ico won't be bypassed, causing the test to fail. To fix the test, I'm adding an optional url_pattern parameter to the bypass verification, that will verify only /exptest/ urls are checked. BUG=488232 Committed: https://crrev.com/d8c12436be2a7c39607fd078383f2519b0a4ac4b Cr-Commit-Position: refs/heads/master@{#330644}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix punctuation in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bustamante
PTAL when you get a chance, this should fix the majority of the waterfall failures ...
5 years, 7 months ago (2015-05-19 22:12:19 UTC) #3
sclittle
LGTM modulo nit https://codereview.chromium.org/1141923004/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/1141923004/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode269 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:269: # Only check the url's that ...
5 years, 7 months ago (2015-05-19 22:17:45 UTC) #4
bustamante
Thanks! https://codereview.chromium.org/1141923004/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/1141923004/diff/1/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode269 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:269: # Only check the url's that contain the ...
5 years, 7 months ago (2015-05-19 22:26:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141923004/20001
5 years, 7 months ago (2015-05-19 22:26:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 22:39:50 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:41:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8c12436be2a7c39607fd078383f2519b0a4ac4b
Cr-Commit-Position: refs/heads/master@{#330644}

Powered by Google App Engine
This is Rietveld 408576698