Issue 11419227: touch: Fix ctrl+taps for buttons on bookmark bar and toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11419227: touch: Fix ctrl+taps for buttons on bookmark bar and toolbar. (Closed)

Created:
8 years ago by sadrul

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

touch: Fix ctrl+taps for buttons on bookmark bar and toolbar. Ctrl+Tapping on the buttons in bookmark bar/toolbar should open a new tab. But since the callbacks looked only at the event-flags for the mouse-events, it didn't work correctly for taps. This is a fix for that. BUG=163377 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170238

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -13 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/reload_button.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/button/button.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/views/controls/button/button.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages