webkit/glue/cpp_bound_class.cc - Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/cpp_bound_class.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/glue/cpp_bound_class.cc

diff --git a/webkit/glue/cpp_bound_class.cc b/webkit/glue/cpp_bound_class.cc

index 75f91fb791a838685f8d073a038bd706c2f3a3e8..18986b99863456b11634db6d5f96875b9c7ed09b 100644

--- a/webkit/glue/cpp_bound_class.cc

+++ b/webkit/glue/cpp_bound_class.cc

@@ -30,7 +30,7 @@ namespace {

class CppVariantPropertyCallback : public CppBoundClass::PropertyCallback {

public:

- CppVariantPropertyCallback(CppVariant* value) : value_(value) { }

+ explicit CppVariantPropertyCallback(CppVariant* value) : value_(value) { }

virtual bool GetValue(CppVariant* value) {

value->Set(*value_);

@@ -47,7 +47,7 @@ class CppVariantPropertyCallback : public CppBoundClass::PropertyCallback {

class GetterPropertyCallback : public CppBoundClass::PropertyCallback {

public:

- GetterPropertyCallback(const CppBoundClass::GetterCallback& callback)

+ explicit GetterPropertyCallback(const CppBoundClass::GetterCallback& callback)

: callback_(callback) { }

virtual bool GetValue(CppVariant* value) {

« no previous file with comments | « webkit/blob/mock_blob_url_request_context.cc ('k') | webkit/glue/image_decoder.h » ('j') | no next file with comments »