Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: ipc/ipc_sync_channel_unittest.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | jingle/glue/fake_network_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_sync_channel_unittest.cc
diff --git a/ipc/ipc_sync_channel_unittest.cc b/ipc/ipc_sync_channel_unittest.cc
index c31565a63e247496ab721b354f9de12d9a7068b1..81834dca64397537bf8a08d01db72622d3ab492a 100644
--- a/ipc/ipc_sync_channel_unittest.cc
+++ b/ipc/ipc_sync_channel_unittest.cc
@@ -344,7 +344,7 @@ class TwoStepServer : public Worker {
class TwoStepClient : public Worker {
public:
- TwoStepClient(bool create_pipe_now)
+ explicit TwoStepClient(bool create_pipe_now)
: Worker(Channel::MODE_CLIENT, "simple_client"),
create_pipe_now_(create_pipe_now) { }
@@ -1247,7 +1247,7 @@ class RestrictedDispatchServer : public Worker {
class NonRestrictedDispatchServer : public Worker {
public:
- NonRestrictedDispatchServer(WaitableEvent* signal_event)
+ explicit NonRestrictedDispatchServer(WaitableEvent* signal_event)
: Worker("non_restricted_channel", Channel::MODE_SERVER),
signal_event_(signal_event) {}
@@ -1770,7 +1770,7 @@ namespace {
class ReentrantReplyServer1 : public Worker {
public:
- ReentrantReplyServer1(WaitableEvent* server_ready)
+ explicit ReentrantReplyServer1(WaitableEvent* server_ready)
: Worker("reentrant_reply1", Channel::MODE_SERVER),
server_ready_(server_ready) { }
@@ -1844,7 +1844,7 @@ class ReentrantReplyServer2 : public Worker {
class ReentrantReplyClient : public Worker {
public:
- ReentrantReplyClient(WaitableEvent* server_ready)
+ explicit ReentrantReplyClient(WaitableEvent* server_ready)
: Worker("reentrant_reply1", Channel::MODE_CLIENT),
server_ready_(server_ready) { }
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | jingle/glue/fake_network_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698