content/app/content_main_runner.cc - Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/app/content_main_runner.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/app/content_main_runner.cc

diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc

index d8d61ca5d87e06ebdc1eff6e6bdf9fadb2f02baa..3e11d5b7051531762d9be5bdc41b6d3c5b66161e 100644

--- a/content/app/content_main_runner.cc

+++ b/content/app/content_main_runner.cc

@@ -186,8 +186,9 @@ void SendTaskPortToParentProcess() {

std::string mach_port_name = MachBroker::GetMachPortName();

base::MachSendMessage child_message(kMessageId);

- if (!child_message.AddDescriptor(mach_task_self())) {

- LOG(ERROR) << "child AddDescriptor(mach_task_self()) failed.";

+ base::MachMsgPortDescriptor descriptor(mach_task_self());

+ if (!child_message.AddDescriptor(descriptor)) {

+ LOG(ERROR) << "child AddDescriptor(descriptor)) failed.";

return;

}