Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2027)

Unified Diff: base/test/trace_event_analyzer.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_runner.cc ('k') | base/thread_task_runner_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_event_analyzer.h
diff --git a/base/test/trace_event_analyzer.h b/base/test/trace_event_analyzer.h
index a472639d0ef54701b8c0a556cc348d36de71eb55..e2bb7de0165f65f715f28b22a1b8a80413c9d80b 100644
--- a/base/test/trace_event_analyzer.h
+++ b/base/test/trace_event_analyzer.h
@@ -352,7 +352,7 @@ class Query {
// Find BEGIN events of given |name| which also have associated END events.
static Query MatchBeginName(const std::string& name) {
- return (Query(EVENT_NAME) == name) && MatchBeginWithEnd();
+ return (Query(EVENT_NAME) == Query(name)) && MatchBeginWithEnd();
}
// Match given Process ID and Thread ID.
@@ -452,16 +452,16 @@ class Query {
};
// Compare with the given member.
- Query(TraceEventMember member);
+ explicit Query(TraceEventMember member);
// Compare with the given member argument value.
Query(TraceEventMember member, const std::string& arg_name);
// Compare with the given string.
- Query(const std::string& str);
+ explicit Query(const std::string& str);
// Compare with the given number.
- Query(double num);
+ explicit Query(double num);
// Construct a boolean Query that returns (left <binary_op> right).
Query(const Query& left, const Query& right, Operator binary_op);
« no previous file with comments | « base/task_runner.cc ('k') | base/thread_task_runner_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698