Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: webkit/tools/test_shell/simple_resource_loader_bridge.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file contains an implementation of the ResourceLoaderBridge class. 5 // This file contains an implementation of the ResourceLoaderBridge class.
6 // The class is implemented using net::URLRequest, meaning it is a "simple" 6 // The class is implemented using net::URLRequest, meaning it is a "simple"
7 // version that directly issues requests. The more complicated one used in the 7 // version that directly issues requests. The more complicated one used in the
8 // browser uses IPC. 8 // browser uses IPC.
9 // 9 //
10 // Because net::URLRequest only provides an asynchronous resource loading API, 10 // Because net::URLRequest only provides an asynchronous resource loading API,
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 884
885 private: 885 private:
886 ResourceLoaderBridge::SyncLoadResponse* result_; 886 ResourceLoaderBridge::SyncLoadResponse* result_;
887 base::WaitableEvent event_; 887 base::WaitableEvent event_;
888 }; 888 };
889 889
890 //----------------------------------------------------------------------------- 890 //-----------------------------------------------------------------------------
891 891
892 class ResourceLoaderBridgeImpl : public ResourceLoaderBridge { 892 class ResourceLoaderBridgeImpl : public ResourceLoaderBridge {
893 public: 893 public:
894 ResourceLoaderBridgeImpl( 894 explicit ResourceLoaderBridgeImpl(
895 const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info) 895 const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info)
896 : params_(new RequestParams), 896 : params_(new RequestParams),
897 proxy_(NULL) { 897 proxy_(NULL) {
898 params_->method = request_info.method; 898 params_->method = request_info.method;
899 params_->url = request_info.url; 899 params_->url = request_info.url;
900 params_->first_party_for_cookies = request_info.first_party_for_cookies; 900 params_->first_party_for_cookies = request_info.first_party_for_cookies;
901 params_->referrer = request_info.referrer; 901 params_->referrer = request_info.referrer;
902 params_->referrer_policy = request_info.referrer_policy; 902 params_->referrer_policy = request_info.referrer_policy;
903 params_->headers = request_info.headers; 903 params_->headers = request_info.headers;
904 params_->load_flags = request_info.load_flags; 904 params_->load_flags = request_info.load_flags;
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 if (!g_file_over_http_mappings) 1150 if (!g_file_over_http_mappings)
1151 g_file_over_http_mappings = new FileOverHTTPPathMappings(); 1151 g_file_over_http_mappings = new FileOverHTTPPathMappings();
1152 g_file_over_http_mappings->AddMapping(file_path_template, http_prefix); 1152 g_file_over_http_mappings->AddMapping(file_path_template, http_prefix);
1153 } 1153 }
1154 1154
1155 // static 1155 // static
1156 webkit_glue::ResourceLoaderBridge* SimpleResourceLoaderBridge::Create( 1156 webkit_glue::ResourceLoaderBridge* SimpleResourceLoaderBridge::Create(
1157 const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info) { 1157 const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info) {
1158 return new ResourceLoaderBridgeImpl(request_info); 1158 return new ResourceLoaderBridgeImpl(request_info);
1159 } 1159 }
OLDNEW
« no previous file with comments | « webkit/support/web_audio_device_mock.h ('k') | webkit/tools/test_shell/test_navigation_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698