Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/base/dialogs/gtk/select_file_dialog_impl.h ('k') | ui/base/dialogs/select_file_dialog.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtk/gtk.h> 5 #include <gtk/gtk.h>
6 #include <map> 6 #include <map>
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/message_loop.h" 12 #include "base/message_loop.h"
13 #include "base/string_util.h" 13 #include "base/string_util.h"
14 #include "base/sys_string_conversions.h" 14 #include "base/sys_string_conversions.h"
15 #include "base/threading/thread.h" 15 #include "base/threading/thread.h"
16 #include "base/threading/thread_restrictions.h" 16 #include "base/threading/thread_restrictions.h"
17 #include "base/utf_string_conversions.h" 17 #include "base/utf_string_conversions.h"
18 #include "grit/ui_strings.h" 18 #include "grit/ui_strings.h"
19 #include "ui/base/dialogs/gtk/select_file_dialog_impl.h" 19 #include "ui/base/dialogs/gtk/select_file_dialog_impl.h"
20 #include "ui/base/dialogs/select_file_dialog.h" 20 #include "ui/base/dialogs/select_file_dialog.h"
21 #include "ui/base/gtk/gtk_signal.h" 21 #include "ui/base/gtk/gtk_signal.h"
22 #include "ui/base/l10n/l10n_util.h" 22 #include "ui/base/l10n/l10n_util.h"
23 23
24 namespace { 24 namespace {
25 25
26 // Implementation of SelectFileDialog that shows a Gtk common dialog for 26 // Implementation of SelectFileDialog that shows a Gtk common dialog for
27 // choosing a file or folder. This acts as a modal dialog. 27 // choosing a file or folder. This acts as a modal dialog.
28 class SelectFileDialogImplGTK : public ui::SelectFileDialogImpl { 28 class SelectFileDialogImplGTK : public ui::SelectFileDialogImpl {
29 public: 29 public:
30 explicit SelectFileDialogImplGTK(Listener* listener, 30 SelectFileDialogImplGTK(Listener* listener,
31 ui::SelectFilePolicy* policy); 31 ui::SelectFilePolicy* policy);
32 32
33 protected: 33 protected:
34 virtual ~SelectFileDialogImplGTK(); 34 virtual ~SelectFileDialogImplGTK();
35 35
36 // SelectFileDialog implementation. 36 // SelectFileDialog implementation.
37 // |params| is user data we pass back via the Listener interface. 37 // |params| is user data we pass back via the Listener interface.
38 virtual void SelectFileImpl(Type type, 38 virtual void SelectFileImpl(Type type,
39 const string16& title, 39 const string16& title,
40 const FilePath& default_path, 40 const FilePath& default_path,
41 const FileTypeInfo* file_types, 41 const FileTypeInfo* file_types,
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 } // namespace 553 } // namespace
554 554
555 namespace ui { 555 namespace ui {
556 556
557 SelectFileDialogImpl* SelectFileDialogImpl::NewSelectFileDialogImplGTK( 557 SelectFileDialogImpl* SelectFileDialogImpl::NewSelectFileDialogImplGTK(
558 Listener* listener, ui::SelectFilePolicy* policy) { 558 Listener* listener, ui::SelectFilePolicy* policy) {
559 return new SelectFileDialogImplGTK(listener, policy); 559 return new SelectFileDialogImplGTK(listener, policy);
560 } 560 }
561 561
562 } // namespace ui 562 } // namespace ui
OLDNEW
« no previous file with comments | « ui/base/dialogs/gtk/select_file_dialog_impl.h ('k') | ui/base/dialogs/select_file_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698