Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: net/url_request/url_request_unittest.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_job.h ('k') | remoting/base/plugin_thread_task_runner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shlobj.h> 9 #include <shlobj.h>
10 #endif 10 #endif
(...skipping 835 matching lines...) Expand 10 before | Expand all | Expand 10 after
846 protected: 846 protected:
847 virtual void StartAsync() { 847 virtual void StartAsync() {
848 this->NotifyRestartRequired(); 848 this->NotifyRestartRequired();
849 } 849 }
850 private: 850 private:
851 ~RestartTestJob() {} 851 ~RestartTestJob() {}
852 }; 852 };
853 853
854 class CancelTestJob : public URLRequestTestJob { 854 class CancelTestJob : public URLRequestTestJob {
855 public: 855 public:
856 explicit CancelTestJob(URLRequest* request, NetworkDelegate* network_delegate) 856 CancelTestJob(URLRequest* request, NetworkDelegate* network_delegate)
857 : URLRequestTestJob(request, network_delegate, true) {} 857 : URLRequestTestJob(request, network_delegate, true) {}
858 protected: 858 protected:
859 virtual void StartAsync() { 859 virtual void StartAsync() {
860 request_->Cancel(); 860 request_->Cancel();
861 } 861 }
862 private: 862 private:
863 ~CancelTestJob() {} 863 ~CancelTestJob() {}
864 }; 864 };
865 865
866 class CancelThenRestartTestJob : public URLRequestTestJob { 866 class CancelThenRestartTestJob : public URLRequestTestJob {
867 public: 867 public:
868 explicit CancelThenRestartTestJob(URLRequest* request, 868 CancelThenRestartTestJob(URLRequest* request,
869 NetworkDelegate* network_delegate) 869 NetworkDelegate* network_delegate)
870 : URLRequestTestJob(request, network_delegate, true) { 870 : URLRequestTestJob(request, network_delegate, true) {
871 } 871 }
872 protected: 872 protected:
873 virtual void StartAsync() { 873 virtual void StartAsync() {
874 request_->Cancel(); 874 request_->Cancel();
875 this->NotifyRestartRequired(); 875 this->NotifyRestartRequired();
876 } 876 }
877 private: 877 private:
878 ~CancelThenRestartTestJob() {} 878 ~CancelThenRestartTestJob() {}
879 }; 879 };
(...skipping 4308 matching lines...) Expand 10 before | Expand all | Expand 10 after
5188 5188
5189 EXPECT_FALSE(r.is_pending()); 5189 EXPECT_FALSE(r.is_pending());
5190 EXPECT_EQ(1, d->response_started_count()); 5190 EXPECT_EQ(1, d->response_started_count());
5191 EXPECT_FALSE(d->received_data_before_response()); 5191 EXPECT_FALSE(d->received_data_before_response());
5192 EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size)); 5192 EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
5193 } 5193 }
5194 } 5194 }
5195 #endif // !defined(DISABLE_FTP_SUPPORT) 5195 #endif // !defined(DISABLE_FTP_SUPPORT)
5196 5196
5197 } // namespace net 5197 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_job.h ('k') | remoting/base/plugin_thread_task_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698