Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: net/socket/client_socket_pool_histograms.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_CLIENT_SOCKET_POOL_HISTOGRAMS_H_ 5 #ifndef NET_SOCKET_CLIENT_SOCKET_POOL_HISTOGRAMS_H_
6 #define NET_SOCKET_CLIENT_SOCKET_POOL_HISTOGRAMS_H_ 6 #define NET_SOCKET_CLIENT_SOCKET_POOL_HISTOGRAMS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/time.h" 11 #include "base/time.h"
12 #include "net/base/net_export.h" 12 #include "net/base/net_export.h"
13 13
14 namespace base { 14 namespace base {
15 class Histogram; 15 class Histogram;
16 } 16 }
17 17
18 namespace net { 18 namespace net {
19 19
20 class NET_EXPORT_PRIVATE ClientSocketPoolHistograms { 20 class NET_EXPORT_PRIVATE ClientSocketPoolHistograms {
21 public: 21 public:
22 ClientSocketPoolHistograms(const std::string& pool_name); 22 explicit ClientSocketPoolHistograms(const std::string& pool_name);
23 ~ClientSocketPoolHistograms(); 23 ~ClientSocketPoolHistograms();
24 24
25 void AddSocketType(int socket_reuse_type) const; 25 void AddSocketType(int socket_reuse_type) const;
26 void AddRequestTime(base::TimeDelta time) const; 26 void AddRequestTime(base::TimeDelta time) const;
27 void AddUnusedIdleTime(base::TimeDelta time) const; 27 void AddUnusedIdleTime(base::TimeDelta time) const;
28 void AddReusedIdleTime(base::TimeDelta time) const; 28 void AddReusedIdleTime(base::TimeDelta time) const;
29 29
30 private: 30 private:
31 base::Histogram* socket_type_; 31 base::Histogram* socket_type_;
32 base::Histogram* request_time_; 32 base::Histogram* request_time_;
33 base::Histogram* unused_idle_time_; 33 base::Histogram* unused_idle_time_;
34 base::Histogram* reused_idle_time_; 34 base::Histogram* reused_idle_time_;
35 35
36 bool is_http_proxy_connection_; 36 bool is_http_proxy_connection_;
37 bool is_socks_connection_; 37 bool is_socks_connection_;
38 38
39 DISALLOW_COPY_AND_ASSIGN(ClientSocketPoolHistograms); 39 DISALLOW_COPY_AND_ASSIGN(ClientSocketPoolHistograms);
40 }; 40 };
41 41
42 } // namespace net 42 } // namespace net
43 43
44 #endif // NET_SOCKET_CLIENT_SOCKET_POOL_HISTOGRAMS_H_ 44 #endif // NET_SOCKET_CLIENT_SOCKET_POOL_HISTOGRAMS_H_
OLDNEW
« no previous file with comments | « net/socket/buffered_write_stream_socket.h ('k') | net/socket/transport_client_socket_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698