Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: net/base/network_config_watcher_mac.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/network_change_notifier.cc ('k') | net/base/server_bound_cert_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/network_config_watcher_mac.h" 5 #include "net/base/network_config_watcher_mac.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 12 matching lines...) Expand all
23 CFArrayRef changed_keys, 23 CFArrayRef changed_keys,
24 void* config_delegate) { 24 void* config_delegate) {
25 NetworkConfigWatcherMac::Delegate* net_config_delegate = 25 NetworkConfigWatcherMac::Delegate* net_config_delegate =
26 static_cast<NetworkConfigWatcherMac::Delegate*>(config_delegate); 26 static_cast<NetworkConfigWatcherMac::Delegate*>(config_delegate);
27 net_config_delegate->OnNetworkConfigChange(changed_keys); 27 net_config_delegate->OnNetworkConfigChange(changed_keys);
28 } 28 }
29 #endif // !defined(OS_IOS) 29 #endif // !defined(OS_IOS)
30 30
31 class NetworkConfigWatcherMacThread : public base::Thread { 31 class NetworkConfigWatcherMacThread : public base::Thread {
32 public: 32 public:
33 NetworkConfigWatcherMacThread(NetworkConfigWatcherMac::Delegate* delegate); 33 explicit NetworkConfigWatcherMacThread(
34 NetworkConfigWatcherMac::Delegate* delegate);
34 virtual ~NetworkConfigWatcherMacThread(); 35 virtual ~NetworkConfigWatcherMacThread();
35 36
36 protected: 37 protected:
37 // base::Thread 38 // base::Thread
38 virtual void Init() OVERRIDE; 39 virtual void Init() OVERRIDE;
39 virtual void CleanUp() OVERRIDE; 40 virtual void CleanUp() OVERRIDE;
40 41
41 private: 42 private:
42 // The SystemConfiguration calls in this function can lead to contention early 43 // The SystemConfiguration calls in this function can lead to contention early
43 // on, so we invoke this function later on in startup to keep it fast. 44 // on, so we invoke this function later on in startup to keep it fast.
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // We create this notifier thread because the notification implementation 124 // We create this notifier thread because the notification implementation
124 // needs a thread with a CFRunLoop, and there's no guarantee that 125 // needs a thread with a CFRunLoop, and there's no guarantee that
125 // MessageLoop::current() meets that criterion. 126 // MessageLoop::current() meets that criterion.
126 base::Thread::Options thread_options(MessageLoop::TYPE_UI, 0); 127 base::Thread::Options thread_options(MessageLoop::TYPE_UI, 0);
127 notifier_thread_->StartWithOptions(thread_options); 128 notifier_thread_->StartWithOptions(thread_options);
128 } 129 }
129 130
130 NetworkConfigWatcherMac::~NetworkConfigWatcherMac() {} 131 NetworkConfigWatcherMac::~NetworkConfigWatcherMac() {}
131 132
132 } // namespace net 133 } // namespace net
OLDNEW
« no previous file with comments | « net/base/network_change_notifier.cc ('k') | net/base/server_bound_cert_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698