Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: jingle/glue/pseudotcp_adapter.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « jingle/glue/mock_task.h ('k') | jingle/glue/pseudotcp_adapter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef JINGLE_GLUE_PSEUDOTCP_ADAPTER_H_ 5 #ifndef JINGLE_GLUE_PSEUDOTCP_ADAPTER_H_
6 #define JINGLE_GLUE_PSEUDOTCP_ADAPTER_H_ 6 #define JINGLE_GLUE_PSEUDOTCP_ADAPTER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/timer.h" 12 #include "base/timer.h"
13 #include "base/threading/non_thread_safe.h" 13 #include "base/threading/non_thread_safe.h"
14 #include "net/base/net_log.h" 14 #include "net/base/net_log.h"
15 #include "net/socket/stream_socket.h" 15 #include "net/socket/stream_socket.h"
16 #include "third_party/libjingle/source/talk/p2p/base/pseudotcp.h" 16 #include "third_party/libjingle/source/talk/p2p/base/pseudotcp.h"
17 17
18 namespace jingle_glue { 18 namespace jingle_glue {
19 19
20 // PseudoTcpAdapter adapts a connectionless net::Socket to a connection- 20 // PseudoTcpAdapter adapts a connectionless net::Socket to a connection-
21 // oriented net::StreamSocket using PseudoTcp. Because net::StreamSockets 21 // oriented net::StreamSocket using PseudoTcp. Because net::StreamSockets
22 // can be deleted during callbacks, while PseudoTcp cannot, the core of the 22 // can be deleted during callbacks, while PseudoTcp cannot, the core of the
23 // PseudoTcpAdapter is reference counted, with a reference held by the 23 // PseudoTcpAdapter is reference counted, with a reference held by the
24 // adapter, and an additional reference held on the stack during callbacks. 24 // adapter, and an additional reference held on the stack during callbacks.
25 class PseudoTcpAdapter : public net::StreamSocket, base::NonThreadSafe { 25 class PseudoTcpAdapter : public net::StreamSocket, base::NonThreadSafe {
26 public: 26 public:
27 // Creates an adapter for the supplied Socket. |socket| should already 27 // Creates an adapter for the supplied Socket. |socket| should already
28 // be ready for use, and ownership of it will be assumed by the adapter. 28 // be ready for use, and ownership of it will be assumed by the adapter.
29 PseudoTcpAdapter(net::Socket* socket); 29 explicit PseudoTcpAdapter(net::Socket* socket);
30 virtual ~PseudoTcpAdapter(); 30 virtual ~PseudoTcpAdapter();
31 31
32 // net::Socket implementation. 32 // net::Socket implementation.
33 virtual int Read(net::IOBuffer* buffer, int buffer_size, 33 virtual int Read(net::IOBuffer* buffer, int buffer_size,
34 const net::CompletionCallback& callback) OVERRIDE; 34 const net::CompletionCallback& callback) OVERRIDE;
35 virtual int Write(net::IOBuffer* buffer, int buffer_size, 35 virtual int Write(net::IOBuffer* buffer, int buffer_size,
36 const net::CompletionCallback& callback) OVERRIDE; 36 const net::CompletionCallback& callback) OVERRIDE;
37 virtual bool SetReceiveBufferSize(int32 size) OVERRIDE; 37 virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;
38 virtual bool SetSendBufferSize(int32 size) OVERRIDE; 38 virtual bool SetSendBufferSize(int32 size) OVERRIDE;
39 39
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 scoped_refptr<Core> core_; 85 scoped_refptr<Core> core_;
86 86
87 net::BoundNetLog net_log_; 87 net::BoundNetLog net_log_;
88 88
89 DISALLOW_COPY_AND_ASSIGN(PseudoTcpAdapter); 89 DISALLOW_COPY_AND_ASSIGN(PseudoTcpAdapter);
90 }; 90 };
91 91
92 } // namespace jingle_glue 92 } // namespace jingle_glue
93 93
94 #endif // JINGLE_GLUE_STREAM_SOCKET_ADAPTER_H_ 94 #endif // JINGLE_GLUE_STREAM_SOCKET_ADAPTER_H_
OLDNEW
« no previous file with comments | « jingle/glue/mock_task.h ('k') | jingle/glue/pseudotcp_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698