Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: jingle/glue/pseudotcp_adapter.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « jingle/glue/pseudotcp_adapter.h ('k') | jingle/glue/thread_wrapper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "jingle/glue/pseudotcp_adapter.h" 5 #include "jingle/glue/pseudotcp_adapter.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "net/base/address_list.h" 10 #include "net/base/address_list.h"
11 #include "net/base/completion_callback.h" 11 #include "net/base/completion_callback.h"
12 #include "net/base/io_buffer.h" 12 #include "net/base/io_buffer.h"
13 #include "net/base/net_errors.h" 13 #include "net/base/net_errors.h"
14 #include "net/base/net_util.h" 14 #include "net/base/net_util.h"
15 15
16 using cricket::PseudoTcp; 16 using cricket::PseudoTcp;
17 17
18 namespace { 18 namespace {
19 const int kReadBufferSize = 65536; // Maximum size of a packet. 19 const int kReadBufferSize = 65536; // Maximum size of a packet.
20 const uint16 kDefaultMtu = 1280; 20 const uint16 kDefaultMtu = 1280;
21 } // namespace 21 } // namespace
22 22
23 namespace jingle_glue { 23 namespace jingle_glue {
24 24
25 class PseudoTcpAdapter::Core : public cricket::IPseudoTcpNotify, 25 class PseudoTcpAdapter::Core : public cricket::IPseudoTcpNotify,
26 public base::RefCounted<Core> { 26 public base::RefCounted<Core> {
27 public: 27 public:
28 Core(net::Socket* socket); 28 explicit Core(net::Socket* socket);
29 29
30 // Functions used to implement net::StreamSocket. 30 // Functions used to implement net::StreamSocket.
31 int Read(net::IOBuffer* buffer, int buffer_size, 31 int Read(net::IOBuffer* buffer, int buffer_size,
32 const net::CompletionCallback& callback); 32 const net::CompletionCallback& callback);
33 int Write(net::IOBuffer* buffer, int buffer_size, 33 int Write(net::IOBuffer* buffer, int buffer_size,
34 const net::CompletionCallback& callback); 34 const net::CompletionCallback& callback);
35 int Connect(const net::CompletionCallback& callback); 35 int Connect(const net::CompletionCallback& callback);
36 void Disconnect(); 36 void Disconnect();
37 bool IsConnected() const; 37 bool IsConnected() const;
38 38
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 DCHECK(CalledOnValidThread()); 597 DCHECK(CalledOnValidThread());
598 core_->SetNoDelay(no_delay); 598 core_->SetNoDelay(no_delay);
599 } 599 }
600 600
601 void PseudoTcpAdapter::SetWriteWaitsForSend(bool write_waits_for_send) { 601 void PseudoTcpAdapter::SetWriteWaitsForSend(bool write_waits_for_send) {
602 DCHECK(CalledOnValidThread()); 602 DCHECK(CalledOnValidThread());
603 core_->SetWriteWaitsForSend(write_waits_for_send); 603 core_->SetWriteWaitsForSend(write_waits_for_send);
604 } 604 }
605 605
606 } // namespace jingle_glue 606 } // namespace jingle_glue
OLDNEW
« no previous file with comments | « jingle/glue/pseudotcp_adapter.h ('k') | jingle/glue/thread_wrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698