Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: content/renderer/pepper/pepper_in_process_router.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/callback.h" 5 #include "base/callback.h"
6 #include "base/basictypes.h" 6 #include "base/basictypes.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "ppapi/proxy/connection.h" 9 #include "ppapi/proxy/connection.h"
10 #include "ppapi/proxy/resource_message_params.h" 10 #include "ppapi/proxy/resource_message_params.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // To keep things consistent, we provide an IPC::Sender for the browser channel 44 // To keep things consistent, we provide an IPC::Sender for the browser channel
45 // in the connection object supplied to resources. This dummy browser channel 45 // in the connection object supplied to resources. This dummy browser channel
46 // will just assert and delete the message if anything is ever sent over it. 46 // will just assert and delete the message if anything is ever sent over it.
47 // 47 //
48 // There are two restrictions for in-process resource calls: 48 // There are two restrictions for in-process resource calls:
49 // Sync messages can only be sent from the plugin to the host. 49 // Sync messages can only be sent from the plugin to the host.
50 // The host must handle sync messages synchronously. 50 // The host must handle sync messages synchronously.
51 class PepperInProcessRouter { 51 class PepperInProcessRouter {
52 public: 52 public:
53 // The given host parameter owns this class and must outlive us. 53 // The given host parameter owns this class and must outlive us.
54 PepperInProcessRouter(RendererPpapiHostImpl* host_impl); 54 explicit PepperInProcessRouter(RendererPpapiHostImpl* host_impl);
55 ~PepperInProcessRouter(); 55 ~PepperInProcessRouter();
56 56
57 // Returns the dummy sender for the cooresponding end of the in-process 57 // Returns the dummy sender for the cooresponding end of the in-process
58 // emulated channel. 58 // emulated channel.
59 IPC::Sender* GetPluginToRendererSender(); 59 IPC::Sender* GetPluginToRendererSender();
60 IPC::Sender* GetRendererToPluginSender(); 60 IPC::Sender* GetRendererToPluginSender();
61 61
62 // Returns a connection pair for use by a resource proxy. This includes 62 // Returns a connection pair for use by a resource proxy. This includes
63 // the plugin->renderer sender as well as a dummy sender to the browser 63 // the plugin->renderer sender as well as a dummy sender to the browser
64 // process. See the class comment above about the dummy sender. 64 // process. See the class comment above about the dummy sender.
(...skipping 29 matching lines...) Expand all
94 94
95 // Reply result of the pending sync message. 95 // Reply result of the pending sync message.
96 bool reply_result_; 96 bool reply_result_;
97 97
98 base::WeakPtrFactory<PepperInProcessRouter> weak_factory_; 98 base::WeakPtrFactory<PepperInProcessRouter> weak_factory_;
99 99
100 DISALLOW_COPY_AND_ASSIGN(PepperInProcessRouter); 100 DISALLOW_COPY_AND_ASSIGN(PepperInProcessRouter);
101 }; 101 };
102 102
103 } // namespace content 103 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/pepper/pepper_file_chooser_host.cc ('k') | content/renderer/pepper/pepper_in_process_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698