Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: content/browser/trace_controller_impl.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/trace_controller_impl.h" 5 #include "content/browser/trace_controller_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/debug/trace_event.h" 9 #include "base/debug/trace_event.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "content/browser/trace_message_filter.h" 11 #include "content/browser/trace_message_filter.h"
12 #include "content/browser/trace_subscriber_stdio.h" 12 #include "content/browser/trace_subscriber_stdio.h"
13 #include "content/common/child_process_messages.h" 13 #include "content/common/child_process_messages.h"
14 #include "content/public/browser/browser_message_filter.h" 14 #include "content/public/browser/browser_message_filter.h"
15 #include "content/public/common/content_switches.h" 15 #include "content/public/common/content_switches.h"
16 16
17 using base::debug::TraceLog; 17 using base::debug::TraceLog;
18 18
19 namespace content { 19 namespace content {
20 20
21 namespace { 21 namespace {
22 22
23 base::LazyInstance<TraceControllerImpl>::Leaky g_controller = 23 base::LazyInstance<TraceControllerImpl>::Leaky g_controller =
24 LAZY_INSTANCE_INITIALIZER; 24 LAZY_INSTANCE_INITIALIZER;
25 25
26 class AutoStopTraceSubscriberStdio : public TraceSubscriberStdio { 26 class AutoStopTraceSubscriberStdio : public TraceSubscriberStdio {
27 public: 27 public:
28 AutoStopTraceSubscriberStdio(const FilePath& file_path) 28 explicit AutoStopTraceSubscriberStdio(const FilePath& file_path)
29 : TraceSubscriberStdio(file_path) {} 29 : TraceSubscriberStdio(file_path) {}
30 30
31 static void EndStartupTrace(TraceSubscriberStdio* subscriber) { 31 static void EndStartupTrace(TraceSubscriberStdio* subscriber) {
32 if (!TraceControllerImpl::GetInstance()->EndTracingAsync(subscriber)) 32 if (!TraceControllerImpl::GetInstance()->EndTracingAsync(subscriber))
33 delete subscriber; 33 delete subscriber;
34 // else, the tracing will end asynchronously in OnEndTracingComplete(). 34 // else, the tracing will end asynchronously in OnEndTracingComplete().
35 } 35 }
36 36
37 virtual void OnEndTracingComplete() { 37 virtual void OnEndTracingComplete() {
38 TraceSubscriberStdio::OnEndTracingComplete(); 38 TraceSubscriberStdio::OnEndTracingComplete();
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 // The last ack represents local trace, so we need to ack it now. Note that 405 // The last ack represents local trace, so we need to ack it now. Note that
406 // this code only executes if there were child processes. 406 // this code only executes if there were child processes.
407 float bpf = TraceLog::GetInstance()->GetBufferPercentFull(); 407 float bpf = TraceLog::GetInstance()->GetBufferPercentFull();
408 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, 408 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
409 base::Bind(&TraceControllerImpl::OnTraceBufferPercentFullReply, 409 base::Bind(&TraceControllerImpl::OnTraceBufferPercentFullReply,
410 base::Unretained(this), bpf)); 410 base::Unretained(this), bpf));
411 } 411 }
412 } 412 }
413 413
414 } // namespace content 414 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/speech/audio_encoder.cc ('k') | content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698