Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: content/browser/device_orientation/provider_impl.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_IMPL_H_
6 #define CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_IMPL_H_ 6 #define CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "content/browser/device_orientation/data_fetcher.h" 14 #include "content/browser/device_orientation/data_fetcher.h"
15 #include "content/browser/device_orientation/device_data.h" 15 #include "content/browser/device_orientation/device_data.h"
16 #include "content/browser/device_orientation/provider.h" 16 #include "content/browser/device_orientation/provider.h"
17 #include "content/common/content_export.h" 17 #include "content/common/content_export.h"
18 18
19 class MessageLoop; 19 class MessageLoop;
20 20
21 namespace content { 21 namespace content {
22 22
23 class ProviderImpl : public Provider { 23 class ProviderImpl : public Provider {
24 public: 24 public:
25 typedef DataFetcher* (*DataFetcherFactory)(); 25 typedef DataFetcher* (*DataFetcherFactory)();
26 26
27 // Create a ProviderImpl that uses the factory to create a DataFetcher that 27 // Create a ProviderImpl that uses the factory to create a DataFetcher that
28 // can provide data. A NULL DataFetcherFactory indicates that there are no 28 // can provide data. A NULL DataFetcherFactory indicates that there are no
29 // DataFetchers for this OS. 29 // DataFetchers for this OS.
30 CONTENT_EXPORT ProviderImpl(DataFetcherFactory factory); 30 CONTENT_EXPORT explicit ProviderImpl(DataFetcherFactory factory);
31 31
32 // From Provider. 32 // From Provider.
33 virtual void AddObserver(Observer* observer) OVERRIDE; 33 virtual void AddObserver(Observer* observer) OVERRIDE;
34 virtual void RemoveObserver(Observer* observer) OVERRIDE; 34 virtual void RemoveObserver(Observer* observer) OVERRIDE;
35 35
36 private: 36 private:
37 class PollingThread; 37 class PollingThread;
38 38
39 virtual ~ProviderImpl(); 39 virtual ~ProviderImpl();
40 40
(...skipping 29 matching lines...) Expand all
70 // Polling is done on this background thread. PollingThread is owned by 70 // Polling is done on this background thread. PollingThread is owned by
71 // the ProviderImpl object. But its deletion doesn't happen synchronously 71 // the ProviderImpl object. But its deletion doesn't happen synchronously
72 // along with deletion of the ProviderImpl. Thus this should be a raw 72 // along with deletion of the ProviderImpl. Thus this should be a raw
73 // pointer instead of scoped_ptr. 73 // pointer instead of scoped_ptr.
74 PollingThread* polling_thread_; 74 PollingThread* polling_thread_;
75 }; 75 };
76 76
77 } // namespace content 77 } // namespace content
78 78
79 #endif // CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_IMPL_H_ 79 #endif // CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/device_orientation/provider.h ('k') | content/browser/dom_storage/dom_storage_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698