Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/renderer/extensions/webstore_bindings.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_EXTENSIONS_WEBSTORE_BINDINGS_H_ 5 #ifndef CHROME_RENDERER_EXTENSIONS_WEBSTORE_BINDINGS_H_
6 #define CHROME_RENDERER_EXTENSIONS_WEBSTORE_BINDINGS_H_ 6 #define CHROME_RENDERER_EXTENSIONS_WEBSTORE_BINDINGS_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "chrome/renderer/extensions/chrome_v8_extension.h" 9 #include "chrome/renderer/extensions/chrome_v8_extension.h"
10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h" 10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 class ChromeV8Context; 13 class ChromeV8Context;
14 14
15 // A V8 extension that creates an object at window.chrome.webstore. This object 15 // A V8 extension that creates an object at window.chrome.webstore. This object
16 // allows JavaScript to initiate inline installs of apps that are listed in the 16 // allows JavaScript to initiate inline installs of apps that are listed in the
17 // Chrome Web Store (CWS). 17 // Chrome Web Store (CWS).
18 class WebstoreBindings : public ChromeV8Extension, 18 class WebstoreBindings : public ChromeV8Extension,
19 public ChromeV8ExtensionHandler { 19 public ChromeV8ExtensionHandler {
20 public: 20 public:
21 explicit WebstoreBindings(Dispatcher* dispatcher, 21 WebstoreBindings(Dispatcher* dispatcher,
22 ChromeV8Context* context); 22 ChromeV8Context* context);
23 23
24 // IPC::Listener 24 // IPC::Listener
25 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 25 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
26 26
27 private: 27 private:
28 v8::Handle<v8::Value> Install(const v8::Arguments& args); 28 v8::Handle<v8::Value> Install(const v8::Arguments& args);
29 29
30 void OnInlineWebstoreInstallResponse( 30 void OnInlineWebstoreInstallResponse(
31 int install_id, bool success, const std::string& error); 31 int install_id, bool success, const std::string& error);
32 32
33 // Extracts a Web Store item ID from a <link rel="chrome-webstore-item" 33 // Extracts a Web Store item ID from a <link rel="chrome-webstore-item"
34 // href="https://chrome.google.com/webstore/detail/id"> node found in the 34 // href="https://chrome.google.com/webstore/detail/id"> node found in the
35 // frame. On success, true will be returned and the |webstore_item_id| 35 // frame. On success, true will be returned and the |webstore_item_id|
36 // parameter will be populated with the ID. On failure, false will be returned 36 // parameter will be populated with the ID. On failure, false will be returned
37 // and |error| will be populated with the error. 37 // and |error| will be populated with the error.
38 static bool GetWebstoreItemIdFromFrame( 38 static bool GetWebstoreItemIdFromFrame(
39 WebKit::WebFrame* frame, const std::string& preferred_store_link_url, 39 WebKit::WebFrame* frame, const std::string& preferred_store_link_url,
40 std::string* webstore_item_id, std::string* error); 40 std::string* webstore_item_id, std::string* error);
41 41
42 DISALLOW_COPY_AND_ASSIGN(WebstoreBindings); 42 DISALLOW_COPY_AND_ASSIGN(WebstoreBindings);
43 }; 43 };
44 44
45 } // namespace extensions 45 } // namespace extensions
46 46
47 #endif // CHROME_RENDERER_EXTENSIONS_WEBSTORE_BINDINGS_H_ 47 #endif // CHROME_RENDERER_EXTENSIONS_WEBSTORE_BINDINGS_H_
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/request_sender.h ('k') | chrome/renderer/net/predictor_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698