Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/renderer/extensions/request_sender.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_EXTENSIONS_REQUEST_SENDER_H_ 5 #ifndef CHROME_RENDERER_EXTENSIONS_REQUEST_SENDER_H_
6 #define CHROME_RENDERER_EXTENSIONS_REQUEST_SENDER_H_ 6 #define CHROME_RENDERER_EXTENSIONS_REQUEST_SENDER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <map> 9 #include <map>
10 10
11 #include "base/memory/linked_ptr.h" 11 #include "base/memory/linked_ptr.h"
12 #include "v8/include/v8.h" 12 #include "v8/include/v8.h"
13 13
14 namespace base { 14 namespace base {
15 class ListValue; 15 class ListValue;
16 } 16 }
17 17
18 namespace extensions { 18 namespace extensions {
19 class ChromeV8ContextSet; 19 class ChromeV8ContextSet;
20 class Dispatcher; 20 class Dispatcher;
21 21
22 struct PendingRequest; 22 struct PendingRequest;
23 23
24 // Responsible for sending requests for named extension API functions to the 24 // Responsible for sending requests for named extension API functions to the
25 // extension host and routing the responses back to the caller. 25 // extension host and routing the responses back to the caller.
26 class RequestSender { 26 class RequestSender {
27 public: 27 public:
28 explicit RequestSender(Dispatcher* dispatcher, 28 RequestSender(Dispatcher* dispatcher,
29 ChromeV8ContextSet* context_set); 29 ChromeV8ContextSet* context_set);
30 ~RequestSender(); 30 ~RequestSender();
31 31
32 // Makes a call to the API function |name| that is to be handled by the 32 // Makes a call to the API function |name| that is to be handled by the
33 // extension host. The response to this request will be received in 33 // extension host. The response to this request will be received in
34 // HandleResponse(). 34 // HandleResponse().
35 // TODO(koz): Remove |request_id| and generate that internally. 35 // TODO(koz): Remove |request_id| and generate that internally.
36 void StartRequest(const std::string& name, 36 void StartRequest(const std::string& name,
37 int request_id, 37 int request_id,
38 bool has_callback, 38 bool has_callback,
39 bool for_io_thread, 39 bool for_io_thread,
(...skipping 15 matching lines...) Expand all
55 Dispatcher* dispatcher_; 55 Dispatcher* dispatcher_;
56 PendingRequestMap pending_requests_; 56 PendingRequestMap pending_requests_;
57 ChromeV8ContextSet* context_set_; 57 ChromeV8ContextSet* context_set_;
58 58
59 DISALLOW_COPY_AND_ASSIGN(RequestSender); 59 DISALLOW_COPY_AND_ASSIGN(RequestSender);
60 }; 60 };
61 61
62 } // namespace extensions 62 } // namespace extensions
63 63
64 #endif // CHROME_RENDERER_EXTENSIONS_REQUEST_SENDER_H_ 64 #endif // CHROME_RENDERER_EXTENSIONS_REQUEST_SENDER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/native_handler.h ('k') | chrome/renderer/extensions/webstore_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698