Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/ui/webui/ntp/suggestions_combiner_unittest.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(beaudoin): What is really needed here? 5 // TODO(beaudoin): What is really needed here?
6 6
7 #include <deque> 7 #include <deque>
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 }; 127 };
128 128
129 } // namespace 129 } // namespace
130 130
131 // Stub for a SuggestionsSource that can provide a number of fake suggestions. 131 // Stub for a SuggestionsSource that can provide a number of fake suggestions.
132 // Fake suggestions are DictionaryValue with a single "title" string field 132 // Fake suggestions are DictionaryValue with a single "title" string field
133 // containing the |source_name| followed by the index of the suggestion. 133 // containing the |source_name| followed by the index of the suggestion.
134 // Not in the empty namespace since it's a friend of SuggestionsCombiner. 134 // Not in the empty namespace since it's a friend of SuggestionsCombiner.
135 class SuggestionsSourceStub : public SuggestionsSource { 135 class SuggestionsSourceStub : public SuggestionsSource {
136 public: 136 public:
137 explicit SuggestionsSourceStub(int weight, 137 SuggestionsSourceStub(int weight,
138 const std::string& source_name, int number_of_suggestions) 138 const std::string& source_name,
139 int number_of_suggestions)
139 : combiner_(NULL), 140 : combiner_(NULL),
140 weight_(weight), 141 weight_(weight),
141 source_name_(source_name), 142 source_name_(source_name),
142 number_of_suggestions_(number_of_suggestions), 143 number_of_suggestions_(number_of_suggestions),
143 debug_(false) { 144 debug_(false) {
144 } 145 }
145 virtual ~SuggestionsSourceStub() { 146 virtual ~SuggestionsSourceStub() {
146 STLDeleteElements(&items_); 147 STLDeleteElements(&items_);
147 } 148 }
148 149
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 } else { 297 } else {
297 EXPECT_EQ(description.results[j], static_cast<const char*>(NULL)) << 298 EXPECT_EQ(description.results[j], static_cast<const char*>(NULL)) <<
298 " test index:" << i; 299 " test index:" << i;
299 } 300 }
300 } 301 }
301 302
302 Reset(); 303 Reset();
303 } 304 }
304 } 305 }
305 306
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/suggestions_combiner.h ('k') | chrome/browser/ui/webui/plugins_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698