Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/ui/cocoa/profile_menu_controller.mm

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/profile_menu_controller.h" 5 #import "chrome/browser/ui/cocoa/profile_menu_controller.h"
6 6
7 #include "base/sys_string_conversions.h" 7 #include "base/sys_string_conversions.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/profiles/avatar_menu_model.h" 9 #include "chrome/browser/profiles/avatar_menu_model.h"
10 #include "chrome/browser/profiles/avatar_menu_model_observer.h" 10 #include "chrome/browser/profiles/avatar_menu_model_observer.h"
(...skipping 13 matching lines...) Expand all
24 24
25 @interface ProfileMenuController (Private) 25 @interface ProfileMenuController (Private)
26 - (void)initializeMenu; 26 - (void)initializeMenu;
27 @end 27 @end
28 28
29 namespace ProfileMenuControllerInternal { 29 namespace ProfileMenuControllerInternal {
30 30
31 class Observer : public chrome::BrowserListObserver, 31 class Observer : public chrome::BrowserListObserver,
32 public AvatarMenuModelObserver { 32 public AvatarMenuModelObserver {
33 public: 33 public:
34 Observer(ProfileMenuController* controller) : controller_(controller) { 34 explicit Observer(ProfileMenuController* controller)
35 : controller_(controller) {
35 BrowserList::AddObserver(this); 36 BrowserList::AddObserver(this);
36 } 37 }
37 38
38 ~Observer() { 39 ~Observer() {
39 BrowserList::RemoveObserver(this); 40 BrowserList::RemoveObserver(this);
40 } 41 }
41 42
42 // chrome::BrowserListObserver: 43 // chrome::BrowserListObserver:
43 virtual void OnBrowserAdded(Browser* browser) {} 44 virtual void OnBrowserAdded(Browser* browser) {}
44 virtual void OnBrowserRemoved(Browser* browser) { 45 virtual void OnBrowserRemoved(Browser* browser) {
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 } 215 }
215 216
216 - (NSMenuItem*)createItemWithTitle:(NSString*)title action:(SEL)sel { 217 - (NSMenuItem*)createItemWithTitle:(NSString*)title action:(SEL)sel {
217 scoped_nsobject<NSMenuItem> item( 218 scoped_nsobject<NSMenuItem> item(
218 [[NSMenuItem alloc] initWithTitle:title action:sel keyEquivalent:@""]); 219 [[NSMenuItem alloc] initWithTitle:title action:sel keyEquivalent:@""]);
219 [item setTarget:self]; 220 [item setTarget:self];
220 return [item.release() autorelease]; 221 return [item.release() autorelease];
221 } 222 }
222 223
223 @end 224 @end
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698