Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <Carbon/Carbon.h> 5 #include <Carbon/Carbon.h>
6 #import <Cocoa/Cocoa.h> 6 #import <Cocoa/Cocoa.h>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/debug/debugger.h" 9 #include "base/debug/debugger.h"
10 #include "base/mac/scoped_nsautorelease_pool.h" 10 #include "base/mac/scoped_nsautorelease_pool.h"
(...skipping 10 matching lines...) Expand all
21 #include "chrome/browser/ui/panels/panel_manager.h" 21 #include "chrome/browser/ui/panels/panel_manager.h"
22 #include "chrome/common/chrome_notification_types.h" 22 #include "chrome/common/chrome_notification_types.h"
23 #include "chrome/common/chrome_switches.h" 23 #include "chrome/common/chrome_switches.h"
24 #include "content/public/test/test_utils.h" 24 #include "content/public/test/test_utils.h"
25 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
26 #include "testing/gtest_mac.h" 26 #include "testing/gtest_mac.h"
27 27
28 class PanelAnimatedBoundsObserver : 28 class PanelAnimatedBoundsObserver :
29 public content::WindowedNotificationObserver { 29 public content::WindowedNotificationObserver {
30 public: 30 public:
31 PanelAnimatedBoundsObserver(Panel* panel) 31 explicit PanelAnimatedBoundsObserver(Panel* panel)
32 : content::WindowedNotificationObserver( 32 : content::WindowedNotificationObserver(
33 chrome::NOTIFICATION_PANEL_BOUNDS_ANIMATIONS_FINISHED, 33 chrome::NOTIFICATION_PANEL_BOUNDS_ANIMATIONS_FINISHED,
34 content::Source<Panel>(panel)) { } 34 content::Source<Panel>(panel)) { }
35 virtual ~PanelAnimatedBoundsObserver() { } 35 virtual ~PanelAnimatedBoundsObserver() { }
36 }; 36 };
37 37
38 // Main test class. 38 // Main test class.
39 class PanelCocoaTest : public CocoaProfileTest { 39 class PanelCocoaTest : public CocoaProfileTest {
40 public: 40 public:
41 virtual void SetUp() { 41 virtual void SetUp() {
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 NSWindow* frontmostWindow = [[NSApp orderedWindows] objectAtIndex:0]; 411 NSWindow* frontmostWindow = [[NSApp orderedWindows] objectAtIndex:0];
412 EXPECT_NSEQ(frontmostWindow, [native_window->controller_ window]); 412 EXPECT_NSEQ(frontmostWindow, [native_window->controller_ window]);
413 413
414 native_window2->ActivatePanel(); 414 native_window2->ActivatePanel();
415 frontmostWindow = [[NSApp orderedWindows] objectAtIndex:0]; 415 frontmostWindow = [[NSApp orderedWindows] objectAtIndex:0];
416 EXPECT_NSEQ(frontmostWindow, [native_window2->controller_ window]); 416 EXPECT_NSEQ(frontmostWindow, [native_window2->controller_ window]);
417 417
418 ClosePanelAndWait(panel); 418 ClosePanelAndWait(panel);
419 ClosePanelAndWait(panel2); 419 ClosePanelAndWait(panel2);
420 } 420 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/panels/panel_cocoa.mm ('k') | chrome/browser/ui/cocoa/profile_menu_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698