Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/browser/ui/cocoa/about_ipc_dialog.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_ABOUT_IPC_DIALOG_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_ABOUT_IPC_DIALOG_H_
6 #define CHROME_BROWSER_UI_COCOA_ABOUT_IPC_DIALOG_H_ 6 #define CHROME_BROWSER_UI_COCOA_ABOUT_IPC_DIALOG_H_
7 7
8 #include "ipc/ipc_logging.h" 8 #include "ipc/ipc_logging.h"
9 #include "ipc/ipc_message_utils.h" 9 #include "ipc/ipc_message_utils.h"
10 10
11 #if defined(IPC_MESSAGE_LOG_ENABLED) 11 #if defined(IPC_MESSAGE_LOG_ENABLED)
12 12
13 #ifdef __OBJC__ 13 #ifdef __OBJC__
14 @class AboutIPCController; 14 @class AboutIPCController;
15 #else 15 #else
16 class AboutIPCController; 16 class AboutIPCController;
17 #endif 17 #endif
18 18
19 19
20 // On Windows, the AboutIPCDialog is a views::View. On Mac we have a 20 // On Windows, the AboutIPCDialog is a views::View. On Mac we have a
21 // Cocoa dialog. This class bridges from C++ to ObjC. 21 // Cocoa dialog. This class bridges from C++ to ObjC.
22 class AboutIPCBridge : public IPC::Logging::Consumer { 22 class AboutIPCBridge : public IPC::Logging::Consumer {
23 public: 23 public:
24 AboutIPCBridge(AboutIPCController* controller) : controller_(controller) { } 24 explicit AboutIPCBridge(AboutIPCController* controller)
25 : controller_(controller) { }
25 virtual ~AboutIPCBridge() { } 26 virtual ~AboutIPCBridge() { }
26 27
27 // IPC::Logging::Consumer implementation. 28 // IPC::Logging::Consumer implementation.
28 virtual void Log(const IPC::LogData& data) OVERRIDE; 29 virtual void Log(const IPC::LogData& data) OVERRIDE;
29 30
30 private: 31 private:
31 AboutIPCController* controller_; // weak; owns me 32 AboutIPCController* controller_; // weak; owns me
32 DISALLOW_COPY_AND_ASSIGN(AboutIPCBridge); 33 DISALLOW_COPY_AND_ASSIGN(AboutIPCBridge);
33 }; 34 };
34 35
35 #endif // IPC_MESSAGE_LOG_ENABLED 36 #endif // IPC_MESSAGE_LOG_ENABLED
36 37
37 #endif // CHROME_BROWSER_UI_COCOA_ABOUT_IPC_DIALOG_H_ 38 #endif // CHROME_BROWSER_UI_COCOA_ABOUT_IPC_DIALOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698