Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/history/in_memory_url_index.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_ 5 #ifndef CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_
6 #define CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_ 6 #define CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_
7 7
8 #include <functional> 8 #include <functional>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 friend class InMemoryURLIndexTest; 143 friend class InMemoryURLIndexTest;
144 friend class InMemoryURLIndexCacheTest; 144 friend class InMemoryURLIndexCacheTest;
145 FRIEND_TEST_ALL_PREFIXES(LimitedInMemoryURLIndexTest, Initialization); 145 FRIEND_TEST_ALL_PREFIXES(LimitedInMemoryURLIndexTest, Initialization);
146 146
147 // Creating one of me without a history path is not allowed (tests excepted). 147 // Creating one of me without a history path is not allowed (tests excepted).
148 InMemoryURLIndex(); 148 InMemoryURLIndex();
149 149
150 // HistoryDBTask used to rebuild our private data from the history database. 150 // HistoryDBTask used to rebuild our private data from the history database.
151 class RebuildPrivateDataFromHistoryDBTask : public HistoryDBTask { 151 class RebuildPrivateDataFromHistoryDBTask : public HistoryDBTask {
152 public: 152 public:
153 explicit RebuildPrivateDataFromHistoryDBTask( 153 RebuildPrivateDataFromHistoryDBTask(
154 InMemoryURLIndex* index, 154 InMemoryURLIndex* index,
155 const std::string& languages, 155 const std::string& languages,
156 const std::set<std::string>& scheme_whitelist); 156 const std::set<std::string>& scheme_whitelist);
157 157
158 virtual bool RunOnDBThread(HistoryBackend* backend, 158 virtual bool RunOnDBThread(HistoryBackend* backend,
159 history::HistoryDatabase* db) OVERRIDE; 159 history::HistoryDatabase* db) OVERRIDE;
160 virtual void DoneRunOnMainThread() OVERRIDE; 160 virtual void DoneRunOnMainThread() OVERRIDE;
161 161
162 private: 162 private:
163 virtual ~RebuildPrivateDataFromHistoryDBTask(); 163 virtual ~RebuildPrivateDataFromHistoryDBTask();
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 // TODO(mrossetti): Eliminate once the transition to SQLite has been done. 284 // TODO(mrossetti): Eliminate once the transition to SQLite has been done.
285 // http://crbug.com/83659 285 // http://crbug.com/83659
286 bool needs_to_be_cached_; 286 bool needs_to_be_cached_;
287 287
288 DISALLOW_COPY_AND_ASSIGN(InMemoryURLIndex); 288 DISALLOW_COPY_AND_ASSIGN(InMemoryURLIndex);
289 }; 289 };
290 290
291 } // namespace history 291 } // namespace history
292 292
293 #endif // CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_ 293 #endif // CHROME_BROWSER_HISTORY_IN_MEMORY_URL_INDEX_H_
OLDNEW
« no previous file with comments | « chrome/browser/google_apis/base_operations.h ('k') | chrome/browser/history/web_history_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698