Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/google_apis/base_operations.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file provides base classes used to implement operations for Google APIs. 5 // This file provides base classes used to implement operations for Google APIs.
6 6
7 #ifndef CHROME_BROWSER_GOOGLE_APIS_BASE_OPERATIONS_H_ 7 #ifndef CHROME_BROWSER_GOOGLE_APIS_BASE_OPERATIONS_H_
8 #define CHROME_BROWSER_GOOGLE_APIS_BASE_OPERATIONS_H_ 8 #define CHROME_BROWSER_GOOGLE_APIS_BASE_OPERATIONS_H_
9 9
10 #include <string> 10 #include <string>
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 public OperationRegistry::Operation, 87 public OperationRegistry::Operation,
88 public net::URLFetcherDelegate { 88 public net::URLFetcherDelegate {
89 public: 89 public:
90 // AuthenticatedOperationInterface overrides. 90 // AuthenticatedOperationInterface overrides.
91 virtual void Start(const std::string& access_token, 91 virtual void Start(const std::string& access_token,
92 const std::string& custom_user_agent, 92 const std::string& custom_user_agent,
93 const ReAuthenticateCallback& callback) OVERRIDE; 93 const ReAuthenticateCallback& callback) OVERRIDE;
94 virtual base::WeakPtr<AuthenticatedOperationInterface> GetWeakPtr() OVERRIDE; 94 virtual base::WeakPtr<AuthenticatedOperationInterface> GetWeakPtr() OVERRIDE;
95 95
96 protected: 96 protected:
97 explicit UrlFetchOperationBase( 97 UrlFetchOperationBase(
98 OperationRegistry* registry, 98 OperationRegistry* registry,
99 net::URLRequestContextGetter* url_request_context_getter); 99 net::URLRequestContextGetter* url_request_context_getter);
100 // Use this constructor when you need to implement operations that take a 100 // Use this constructor when you need to implement operations that take a
101 // drive file path (ex. for downloading and uploading). 101 // drive file path (ex. for downloading and uploading).
102 // |url_request_context_getter| is used to initialize URLFetcher. 102 // |url_request_context_getter| is used to initialize URLFetcher.
103 // TODO(satorux): Remove the drive file path hack. crbug.com/163296 103 // TODO(satorux): Remove the drive file path hack. crbug.com/163296
104 UrlFetchOperationBase( 104 UrlFetchOperationBase(
105 OperationRegistry* registry, 105 OperationRegistry* registry,
106 net::URLRequestContextGetter* url_request_context_getter, 106 net::URLRequestContextGetter* url_request_context_getter,
107 OperationType type, 107 OperationType type,
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 254
255 // Note: This should remain the last member so it'll be destroyed and 255 // Note: This should remain the last member so it'll be destroyed and
256 // invalidate its weak pointers before any other members are destroyed. 256 // invalidate its weak pointers before any other members are destroyed.
257 base::WeakPtrFactory<GetDataOperation> weak_ptr_factory_; 257 base::WeakPtrFactory<GetDataOperation> weak_ptr_factory_;
258 DISALLOW_COPY_AND_ASSIGN(GetDataOperation); 258 DISALLOW_COPY_AND_ASSIGN(GetDataOperation);
259 }; 259 };
260 260
261 } // namespace google_apis 261 } // namespace google_apis
262 262
263 #endif // CHROME_BROWSER_GOOGLE_APIS_BASE_OPERATIONS_H_ 263 #endif // CHROME_BROWSER_GOOGLE_APIS_BASE_OPERATIONS_H_
OLDNEW
« no previous file with comments | « chrome/browser/geolocation/chrome_access_token_store.cc ('k') | chrome/browser/history/in_memory_url_index.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698