Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: cc/picture.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/managed_memory_policy.h ('k') | cc/picture_layer_tiling_set.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_PICTURE_H_ 5 #ifndef CC_PICTURE_H_
6 #define CC_PICTURE_H_ 6 #define CC_PICTURE_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 29 matching lines...) Expand all
40 bool HasRecording() const { return picture_.get(); } 40 bool HasRecording() const { return picture_.get(); }
41 41
42 // Raster this Picture's layer_rect into the given canvas. 42 // Raster this Picture's layer_rect into the given canvas.
43 // Assumes contentsScale have already been applied. 43 // Assumes contentsScale have already been applied.
44 void Raster(SkCanvas* canvas); 44 void Raster(SkCanvas* canvas);
45 45
46 void GatherPixelRefs(const gfx::Rect& rect, 46 void GatherPixelRefs(const gfx::Rect& rect,
47 std::list<skia::LazyPixelRef*>&); 47 std::list<skia::LazyPixelRef*>&);
48 48
49 private: 49 private:
50 Picture(gfx::Rect layer_rect); 50 explicit Picture(gfx::Rect layer_rect);
51 // This constructor assumes SkPicture is already ref'd and transfers 51 // This constructor assumes SkPicture is already ref'd and transfers
52 // ownership to this picture. 52 // ownership to this picture.
53 Picture(const skia::RefPtr<SkPicture>&, 53 Picture(const skia::RefPtr<SkPicture>&,
54 gfx::Rect layer_rect, 54 gfx::Rect layer_rect,
55 gfx::Rect opaque_rect); 55 gfx::Rect opaque_rect);
56 ~Picture(); 56 ~Picture();
57 57
58 gfx::Rect layer_rect_; 58 gfx::Rect layer_rect_;
59 gfx::Rect opaque_rect_; 59 gfx::Rect opaque_rect_;
60 skia::RefPtr<SkPicture> picture_; 60 skia::RefPtr<SkPicture> picture_;
61 61
62 friend class base::RefCountedThreadSafe<Picture>; 62 friend class base::RefCountedThreadSafe<Picture>;
63 DISALLOW_COPY_AND_ASSIGN(Picture); 63 DISALLOW_COPY_AND_ASSIGN(Picture);
64 }; 64 };
65 65
66 } // namespace cc 66 } // namespace cc
67 67
68 #endif // CC_PICTURE_H_ 68 #endif // CC_PICTURE_H_
OLDNEW
« no previous file with comments | « cc/managed_memory_policy.h ('k') | cc/picture_layer_tiling_set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698