Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Side by Side Diff: base/threading/thread_collision_warner.h

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/threading/thread_checker_unittest.cc ('k') | base/threading/worker_pool.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_THREAD_COLLISION_WARNER_H_ 5 #ifndef BASE_THREADING_THREAD_COLLISION_WARNER_H_
6 #define BASE_THREADING_THREAD_COLLISION_WARNER_H_ 6 #define BASE_THREADING_THREAD_COLLISION_WARNER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/atomicops.h" 10 #include "base/atomicops.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 }; 137 };
138 138
139 struct BASE_EXPORT DCheckAsserter : public AsserterBase { 139 struct BASE_EXPORT DCheckAsserter : public AsserterBase {
140 virtual ~DCheckAsserter() {} 140 virtual ~DCheckAsserter() {}
141 virtual void warn() OVERRIDE; 141 virtual void warn() OVERRIDE;
142 }; 142 };
143 143
144 class BASE_EXPORT ThreadCollisionWarner { 144 class BASE_EXPORT ThreadCollisionWarner {
145 public: 145 public:
146 // The parameter asserter is there only for test purpose 146 // The parameter asserter is there only for test purpose
147 ThreadCollisionWarner(AsserterBase* asserter = new DCheckAsserter()) 147 explicit ThreadCollisionWarner(AsserterBase* asserter = new DCheckAsserter())
148 : valid_thread_id_(0), 148 : valid_thread_id_(0),
149 counter_(0), 149 counter_(0),
150 asserter_(asserter) {} 150 asserter_(asserter) {}
151 151
152 ~ThreadCollisionWarner() { 152 ~ThreadCollisionWarner() {
153 delete asserter_; 153 delete asserter_;
154 } 154 }
155 155
156 // This class is meant to be used through the macro 156 // This class is meant to be used through the macro
157 // DFAKE_SCOPED_LOCK_THREAD_LOCKED 157 // DFAKE_SCOPED_LOCK_THREAD_LOCKED
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 // Here only for class unit tests purpose, during the test I need to not 235 // Here only for class unit tests purpose, during the test I need to not
236 // DCHECK but notify the collision with something else. 236 // DCHECK but notify the collision with something else.
237 AsserterBase* asserter_; 237 AsserterBase* asserter_;
238 238
239 DISALLOW_COPY_AND_ASSIGN(ThreadCollisionWarner); 239 DISALLOW_COPY_AND_ASSIGN(ThreadCollisionWarner);
240 }; 240 };
241 241
242 } // namespace base 242 } // namespace base
243 243
244 #endif // BASE_THREADING_THREAD_COLLISION_WARNER_H_ 244 #endif // BASE_THREADING_THREAD_COLLISION_WARNER_H_
OLDNEW
« no previous file with comments | « base/threading/thread_checker_unittest.cc ('k') | base/threading/worker_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698