Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: base/task_runner.cc

Issue 11419224: Add missing (and remove superfluous) 'explicit' from constructors. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + remove non-straightforward changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/synchronization/lock_unittest.cc ('k') | base/test/trace_event_analyzer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_runner.h" 5 #include "base/task_runner.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/threading/post_task_and_reply_impl.h" 9 #include "base/threading/post_task_and_reply_impl.h"
10 10
11 namespace base { 11 namespace base {
12 12
13 namespace { 13 namespace {
14 14
15 // TODO(akalin): There's only one other implementation of 15 // TODO(akalin): There's only one other implementation of
16 // PostTaskAndReplyImpl in WorkerPool. Investigate whether it'll be 16 // PostTaskAndReplyImpl in WorkerPool. Investigate whether it'll be
17 // possible to merge the two. 17 // possible to merge the two.
18 class PostTaskAndReplyTaskRunner : public internal::PostTaskAndReplyImpl { 18 class PostTaskAndReplyTaskRunner : public internal::PostTaskAndReplyImpl {
19 public: 19 public:
20 PostTaskAndReplyTaskRunner(TaskRunner* destination); 20 explicit PostTaskAndReplyTaskRunner(TaskRunner* destination);
21 21
22 private: 22 private:
23 virtual bool PostTask(const tracked_objects::Location& from_here, 23 virtual bool PostTask(const tracked_objects::Location& from_here,
24 const Closure& task) OVERRIDE; 24 const Closure& task) OVERRIDE;
25 25
26 // Non-owning. 26 // Non-owning.
27 TaskRunner* destination_; 27 TaskRunner* destination_;
28 }; 28 };
29 29
30 PostTaskAndReplyTaskRunner::PostTaskAndReplyTaskRunner( 30 PostTaskAndReplyTaskRunner::PostTaskAndReplyTaskRunner(
(...skipping 28 matching lines...) Expand all
59 59
60 void TaskRunner::OnDestruct() const { 60 void TaskRunner::OnDestruct() const {
61 delete this; 61 delete this;
62 } 62 }
63 63
64 void TaskRunnerTraits::Destruct(const TaskRunner* task_runner) { 64 void TaskRunnerTraits::Destruct(const TaskRunner* task_runner) {
65 task_runner->OnDestruct(); 65 task_runner->OnDestruct();
66 } 66 }
67 67
68 } // namespace base 68 } // namespace base
OLDNEW
« no previous file with comments | « base/synchronization/lock_unittest.cc ('k') | base/test/trace_event_analyzer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698